Skip to content

RAL-195: the brief counts a merged story as not live only when the service's code changed - #281

Merged
Castor-o7 merged 2 commits into
mainfrom
ral-brief-not-live
Nov 15, 2026
Merged

Castor-o7 merged 2 commits into
mainfrom
ral-brief-not-live

Conversation

@Castor-o7

Copy link
Copy Markdown
Owner

Why

rally brief --watchman read "8 stories merged, not live; the oldest for 32 h" (RAL-186 to 193) because it compared main with the service's commit. The service, the viewer and the CLI are one binary, and none of those commits changed what the service runs.

What

  • Each story merged since the service's build says what it waits_on, from GitHub's file list for each commit that names it:
    • service: a file the service runs changed (builds::SERVICE_MODULES, Cargo.toml, Cargo.lock, build.rs). Only these are counted, and the oldest age is theirs.
    • can't tell: only files the service shares changed (src/main.rs, src/web.rs, src/lib.rs unless the patch only names client modules), or a commit's files couldn't be read. Never called live.
    • cli or viewer, or nothing running (docs and tests).
  • cli_build says this CLI's commit, how far behind main it is and which stories it lacks. viewer_build says the build of the viewer rally view started on this machine.
  • The "staged" hint shows only when a story waits on the service or can't be told.
  • Past 60 commits naming a story the files aren't read; files_unread says so and every story counts as before.

Against today's service (de27b43, main 7266432)

0 stories wait on the service; RAL-187, 188 and 191 can't be told because they change src/main.rs; the other 5 change only the CLI, the viewer, docs or tests. The brief took 2.4 s.

Limit

src/main.rs holds every command, serve among them, so the path alone can't clear a story that touches it. Moving serve's wiring into its own file would let paths tell; that is not in this PR.

Tests

cargo fmt --check, cargo clippy --all-targets -- -D warnings and cargo test pass locally. New tests in src/builds.rs: each reading, the path placement, and one that keeps every file in src/ placed as the service's, shared or the client's.

🤖 Generated with Claude Code

Castor-o7 and others added 2 commits November 15, 2026 17:47
…rvice's code changed

rally brief --watchman read "8 stories merged, not live" of commits that changed only the
CLI, the viewer, docs and tests, because it compared main with the service's commit. Each
story now says what it waits on, from the files its commits change: the service, can't tell
(only files the service shares, such as src/main.rs), the CLI or viewer, or nothing running.
Only the first is counted. The section also says which build this CLI and the viewer are on.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sent back at 4cbfbc7: only commits whose first line names a story had their files read, so
a service change in a commit such as "address review" would go unreported. Now the files
of each commit on main's first-parent chain are read: a pull request's merge lists all it
changed, whatever its commits are called. They go to the stories the commit names or
brought; a commit that names none is listed by its sha, counts toward waiting on the
service, and keeps the staged hint.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@Castor-o7
Castor-o7 merged commit ee9af34 into main Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant