Repository navigation
RAL-195: the brief counts a merged story as not live only when the service's code changed - #281
Merged
Merged
Conversation
…rvice's code changed rally brief --watchman read "8 stories merged, not live" of commits that changed only the CLI, the viewer, docs and tests, because it compared main with the service's commit. Each story now says what it waits on, from the files its commits change: the service, can't tell (only files the service shares, such as src/main.rs), the CLI or viewer, or nothing running. Only the first is counted. The section also says which build this CLI and the viewer are on. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sent back at 4cbfbc7: only commits whose first line names a story had their files read, so a service change in a commit such as "address review" would go unreported. Now the files of each commit on main's first-parent chain are read: a pull request's merge lists all it changed, whatever its commits are called. They go to the stories the commit names or brought; a commit that names none is listed by its sha, counts toward waiting on the service, and keeps the staged hint. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
rally brief --watchmanread "8 stories merged, not live; the oldest for 32 h" (RAL-186 to 193) because it compared main with the service's commit. The service, the viewer and the CLI are one binary, and none of those commits changed what the service runs.What
waits_on, from GitHub's file list for each commit that names it:service: a file the service runs changed (builds::SERVICE_MODULES,Cargo.toml,Cargo.lock,build.rs). Only these are counted, and the oldest age is theirs.can't tell: only files the service shares changed (src/main.rs,src/web.rs,src/lib.rsunless the patch only names client modules), or a commit's files couldn't be read. Never called live.cli or viewer, ornothing running(docs and tests).cli_buildsays this CLI's commit, how far behind main it is and which stories it lacks.viewer_buildsays the build of the viewerrally viewstarted on this machine.files_unreadsays so and every story counts as before.Against today's service (de27b43, main 7266432)
0 stories wait on the service; RAL-187, 188 and 191 can't be told because they change
src/main.rs; the other 5 change only the CLI, the viewer, docs or tests. The brief took 2.4 s.Limit
src/main.rsholds every command,serveamong them, so the path alone can't clear a story that touches it. Moving serve's wiring into its own file would let paths tell; that is not in this PR.Tests
cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass locally. New tests insrc/builds.rs: each reading, the path placement, and one that keeps every file insrc/placed as the service's, shared or the client's.🤖 Generated with Claude Code