Repository navigation
Description
Task
T-056a· Milestone M5 — Intelligent selection · Size S · Priority P0 · Epic #5Implements FR-SEL-002 · FR-SEL-004
Branch
feat/t-056a-acquisitions-qlognei-wrapper-expected-violation— one task = one branch = one PR (doc 32 §6)
Summary
Implement selection/acquisition.py analytic/BoTorch acquisitions of doc 07 §5.1, §5.2, §5.4: qLogNEI on −ρ with X_pending, EV(x) = (−μ)Φ(z) + σφ(z), α_boundary = β·σ − |μ|.
Context / motivation
These encode the selector's three goals: falsification, failure-mode search, boundary characterisation (doc 07 §1).
Scope
In scope
- BoTorch
AcquisitionFunctionsubclasses for EV and straddle (batch shapeb×1×d), numerically stablelog EV.
Implementation guidance
- Use
torch.special/botorch.utils.probabilityhelpers for log-domain stability. - Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff
PLR2004); public APIs typed (mypy strict) and documented.
Configuration keys
From the configuration reference (doc 27). Keys marked (new) must be added to the typed settings models and appear in the generated reference (T-003c).
selection.probe.beta_straddle
Acceptance criteria
- Analytic checks of EV and straddle against hand-computed values.
- qLogNEI respects pending points (no proposal at a pending x).
- Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
- Docs, config reference and CHANGELOG
Unreleasedupdated where behaviour, keys or interfaces changed. - Definition of Done (doc 32 §3) satisfied.
Tests required
tests/unit/selection/test_acquisition.py.
Dependencies
Blocked by: #110 (T-055a)
Blocks: #113 (T-056b), #114 (T-056c)
Parallelization notes
Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:
backend/src/roboprobe/selection/acquisition.py
T-056b/T-056c add sibling modules.
Definition of Done
Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-056a (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.
References
Design docs: doc 07 §5.1 · doc 07 §5.2 · doc 07 §5.4
Requirements: FR-SEL-002 · FR-SEL-004 (traceability: doc 28)
External:
Metadata
Metadata
Assignees
Labels
Projects
- StatusShow more project fieldsBacklog
Activity