Skip to content

[T-056c] Batch proposals: Kriging Believer + acquisition optimiser wrapper (restarts, tabu, dedupe, seeding) #114

Closed

Description

@CodewithJha

Task T-056c · Milestone M5 — Intelligent selection · Size S · Priority P0 · Epic #5

Implements FR-SEL-006

Branch feat/t-056c-batch-proposals-kriging-believer-acquisition — one task = one branch = one PR (doc 32 §6)

Summary

Implement selection/optimize.py: optimize_acqf wrapper with num_restarts, raw_samples, maxiter, seeded torch.Generator; constraint handling by rejection + tabu (max 3 tries, then best feasible raw sample); and greedy Kriging-Believer batches via condition_on_observations (doc 07 §5.6–5.7).

Context / motivation

Parallel workers need q distinct proposals per tick (FR-SEL-006 AC: pairwise normalised distance > 1e-3).

Scope

In scope

  • optimize(acq, space, rng, settings) -> x, kriging_believer_batch(gp, acq_factory, q, ...) -> list[x].
  • Integer relaxation + rounding hook (doc 07 §5.5) — categoricals out of scope for warehouse_v1 (document).

Implementation guidance

  • Fantasy conditioning must not refit hyper-parameters.
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Configuration keys

From the configuration reference (doc 27). Keys marked (new) must be added to the typed settings models and appear in the generated reference (T-003c).

  • selection.acq.num_restarts
  • selection.acq.raw_samples
  • selection.acq.maxiter
  • selection.acq.dedupe_tol

Acceptance criteria

  • q=4 returns 4 pairwise-distinct feasible points.
  • Deterministic with seed.
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • tests/unit/selection/test_optimize.py.

Dependencies

Blocked by: #112 (T-056a)

Blocks: #115 (T-057), #116 (T-058), #119 (T-059c)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • backend/src/roboprobe/selection/optimize.py

Parallel with T-056b.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-056c (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 07 §5.5 · doc 07 §5.6 · doc 07 §5.7

Requirements: FR-SEL-006 (traceability: doc 28)

External:

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:selectionScenario selection strategies (BO, LSE, PROBE, baselines)milestone:M5M5 — Intelligent selectionpriority:P0Critical path / blocks otherssize:S<= 1 daytaskChild task of a milestone epictype:featureNew functionality

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions