Skip to content

[T-060] Strategy params validation and exposure via /meta (schemas for the wizard) #120

Closed

Description

@CodewithJha

Task T-060 · Milestone M5 — Intelligent selection · Size XS · Priority P1 · Epic #5

Implements FR-SEL-008

Branch feat/t-060-strategy-params-validation-and-exposure — one task = one branch = one PR (doc 32 §6)

Summary

Provide registry.describe() -> list[StrategyInfo] (id, family, plain-language description, JSON Schema of params with defaults from SelectionDefaults) used by the API /meta endpoint and the wizard's Advanced accordion.

Context / motivation

Doc 13 §3.2 step 3: params validated from /meta; invalid params must be rejected at campaign creation.

Scope

In scope

  • Description strings per strategy (doc 13 §3.2 tone, e.g. 'Learns where failures hide and probes there').
  • Validation helper used by CampaignCreate (T-081b).

Implementation guidance

  • JSON Schema from Params.model_json_schema().
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • Invalid params → VALIDATION_ERROR with field path.
  • All strategies described.
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • tests/unit/selection/test_describe.py.

Dependencies

Blocked by: #119 (T-059c)

Blocks: #147 (T-081b), #170 (T-087b)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • backend/src/roboprobe/selection/registry.py (describe)

Small.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-060 (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 07 §6.3 · doc 07 §10 · doc 13 §3.2 · doc 12 §2

Requirements: FR-SEL-008 (traceability: doc 28)

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:apiREST + SSE API (FastAPI)area:selectionScenario selection strategies (BO, LSE, PROBE, baselines)good first issueGood for newcomersmilestone:M5M5 — Intelligent selectionpriority:P1Required for milestone exitsize:XS< 2 hourstaskChild task of a milestone epictype:featureNew functionality

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions