Repository navigation
Description
Task
T-059c· Milestone M5 — Intelligent selection · Size M · Priority P0 · Epic #5Implements FR-SEL-003 · FR-SEL-008 · PR-03
Branch
feat/t-059c-s-probe-strategy-assembly-probestrategy— one task = one branch = one PR (doc 32 §6)
Summary
Implement selection/probe.py ProbeStrategy following the pseudocode of doc 07 §6.2 (GP refit per call, Falsify until first failure, per-slot phase choice with Kriging Believer), recording rationale per proposal, and registering it as the default strategy.
Context / motivation
RoboProbe's core contribution — the intelligent strategy (PR-03).
Scope
In scope
- Entry point
S-PROBE;ProbeParamsmodel (07 §6.3). - Fallback to Sobol on GP failure (+
selector.fallback). - State: Sobol index, phase controller state, refine plans, mode cache.
Implementation guidance
- Keep
probe.py< 400 lines by delegating towarmup.py,probe_phases.py,refine.py,diversity.py,optimize.py. - Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff
PLR2004); public APIs typed (mypy strict) and documented.
Acceptance criteria
- Benchmark gates (doc 18 §4.4): finds ≥ 3/4 modes in ≥ 80 % of 20 seeds within 150 evals; median first failure ≤ 0.5 × S-RANDOM median on
multi_mode_6d. -
propose(q=4)≤ 2 s at n=500, d=8 (NFR-PERF-002). - Contract suite passes; state round-trip reproduces next proposals.
- Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
- Docs, config reference and CHANGELOG
Unreleasedupdated where behaviour, keys or interfaces changed. - Definition of Done (doc 32 §3) satisfied.
Tests required
tests/benchmark/test_probe_multimode.py, contract suite.
Dependencies
Blocked by: #117 (T-059a), #118 (T-059b), #113 (T-056b), #114 (T-056c), #103 (T-052)
Blocks: #120 (T-060), #121 (T-053), #122 (T-061), #218 (T-131)
Parallelization notes
Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:
backend/src/roboprobe/selection/probe.py
Integration point of the selection stream.
Definition of Done
Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-059c (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.
References
Design docs: doc 07 §6 · doc 07 §6.2 · doc 07 §6.3 · doc 07 §6.4 · doc 07 §11 · ADR-0005
Requirements: FR-SEL-003 · FR-SEL-008 · PR-03 (traceability: doc 28)
Metadata
Metadata
Assignees
Labels
Projects
- StatusShow more project fieldsBacklog
Activity
branin_falsify,multi_mode_6d) and benchmark backend #103/meta(schemas for the wizard) #120benchmark-smokeCI job #121