Skip to content

[T-113a] Spaces (list, YAML viewer, validation), Workbench (workers) and Settings (token, theme, format, SSE status) #182

Closed

Description

@CodewithJha

Task T-113a · Milestone M8 — Dashboard · Size M · Priority P1 · Epic #8

Implements FR-DSH-008 · FR-SCN-001

Branch feat/t-113a-spaces-list-yaml-viewer-validation — one task = one branch = one PR (doc 32 §6)

Summary

Implement features/spaces/, features/workbench/ and features/settings/ per doc 13 §3.8: spaces list + YAML viewer with server validation messages + parameter table; workers table (backend, status, current run, heartbeat age, version); settings (API token stored in sessionStorage, theme, number format, SSE status).

Context / motivation

Secondary screens needed for a complete product.

Scope

In scope

  • Token never written to localStorage or logs (TM-01).

Implementation guidance

  • features/spaces/: list (useSpaces); detail /spaces/:id/:version with a read-only YAML viewer (<pre> with CSS-based tinting, no heavy editor), parameter table (name, unit, range, scale, nominal, enabled) and a validation panel calling POST /spaces/validate for pasted YAML, showing pointer-located errors.
  • features/workbench/: workers StatTable (backend, status, current run link, heartbeat age highlighted when stale beyond a threshold from /meta, version); live via worker.updated.
  • features/settings/: API token field (in sessionStorage only, masked; "test connection" calls /meta), theme (system/light/dark), number locale, SSE status + reconnect button, app/API versions.
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • Each screen renders fixtures; token persistence scoped to session.
  • Token never written to localStorage (test inspects storage).
  • Heartbeat staleness threshold not hard-coded (from /meta).
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • Tests per feature folder.

Dependencies

Blocked by: #165 (T-085d), #167 (T-086b)

Blocks: #188 (T-114)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • web/src/features/spaces/**
  • web/src/features/workbench/**
  • web/src/features/settings/**

Three independent folders (may be split across agents).

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-113a (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 13 §3.8 · doc 31 §3

Requirements: FR-DSH-008 · FR-SCN-001 (traceability: doc 28)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions