Skip to content

[T-114] Accessibility & performance pass: axe on all routes, keyboard audit, Lighthouse ≥ 95, bundle ≤ 350 KB gzip #188

Closed

Description

@CodewithJha

Task T-114 · Milestone M8 — Dashboard · Size S · Priority P1 · Epic #8

Implements NFR-ACC-001 · NFR-PERF-004

Branch test/t-114-accessibility-performance-pass-axe-on — one task = one branch = one PR (doc 32 §6)

Summary

Add a route-sweep spec running axe on every route (light + dark theme), a Lighthouse CI job (accessibility ≥ 95), and a bundle-size check (size-limit or rollup visualizer budget) failing CI above 350 KB gzip initial JS; fix findings.

Context / motivation

Doc 13 §7 usability acceptance.

Scope

In scope

  • Manual keyboard audit checklist in docs/evidence/T-114-a11y.md.

Implementation guidance

  • a11y-sweep.spec.ts: iterate over every route (seeded ids) in both themes, run axe, then Tab through each page asserting visible focus and no keyboard traps.
  • Lighthouse CI (lighthouserc.json): collect /, /campaigns/<seed>, /runs/<seed> with preset: desktop; assert categories:accessibility >= 0.95, performance warn-only; run in e2e.yml nightly.
  • Bundle budget: size-limit on the initial JS, gzip ≤ 350 KB (doc 13 §7), as a CI step in the web job.
  • Fix findings in the owning feature folders (small PRs per feature if fixes are large).
  • docs/evidence/T-114-a11y.md: tools/versions, scores, manual keyboard and screen-reader (NVDA/VoiceOver) spot-check notes.
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • CI gates added and green.
  • Evidence file committed.
  • Lighthouse accessibility ≥ 95 on the three pages.
  • Bundle budget enforced in CI.
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • CI jobs + route sweep spec.

Dependencies

Blocked by: #187 (T-118), #184 (T-115), #181 (T-112b), #182 (T-113a)

Blocks: #222 (T-121)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • web/e2e/specs/a11y-sweep.spec.ts
  • web/.size-limit.json
  • web/lighthouserc.json
  • .github/workflows/e2e.yml (jobs)
  • docs/evidence/T-114-a11y.md

Final M8 polish.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-114 (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 13 §7 · doc 02 §5

Requirements: NFR-ACC-001 · NFR-PERF-004 (traceability: doc 28)

External:

Activity

  1. added this to the M8 — Dashboard milestone on Nov 19, 2026
  2. added
    type:testTest suites and test infrastructure
    area:ciCI/CD workflows
    priority:P1Required for milestone exit
    taskChild task of a milestone epic
    on Nov 19, 2026
  3. CodewithJha commented on Nov 22, 2026

    @CodewithJha
    OwnerAuthor

    Shipped on main (Playwright E2E stack: #332, #330).

  4. added a commit that references this issue on Nov 22, 2026
    9669e5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciCI/CD workflowsarea:dashboardReact web dashboardmilestone:M8M8 — Dashboardpriority:P1Required for milestone exitsize:S<= 1 daytaskChild task of a milestone epictype:testTest suites and test infrastructure

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions