Skip to content

[T-092] Map, goal pose and nominal path for warehouse_delivery_v1 (resolve TBD_T092) #191

Closed

Description

@CodewithJha

Task T-092 · Milestone M9 — Gazebo backend · Size S · Priority P0 · Epic #9

Implements FR-SIM-003 · FR-SCN-002

Branch spike/t-092-map-goal-pose-and-nominal — one task = one branch = one PR (doc 32 §6)

Summary

Produce the occupancy map (from the warehouse world, e.g. via slam_toolbox run or the provided map), choose start/goal poses, compute and store the nominal path (planner output) used by place_obstacle, and align the kinematic2d world clone (T-032) with the same geometry.

Context / motivation

Both backends must test the same task so results are comparable (doc 06 §1).

Scope

In scope

  • configs/maps/warehouse_v1.{pgm,yaml}, nominal_path.json; doc update in 06 §7 if values change.

Implementation guidance

  • Map: prefer the warehouse map shipped with nav2_minimal_tb4_sim if present; otherwise generate it with slam_toolbox (online async) in sim along a scripted route and save with ros2 run nav2_map_server map_saver_cli -f warehouse_v1.
  • Choose start/goal so the nominal path passes the aisle where the pallet is placed (doc 06 §1) with nominal clearance well above clear.d_safe; compute the nominal path once via the planner (ComputePathToPose) and store it as configs/maps/warehouse_v1_nominal_path.json ([[x, y], …]), used by place_obstacle (T-028) on both backends.
  • Align the k2d world (T-032) with scripts/compare_maps.py, which computes the IoU of occupied cells after aligning origins and compares nominal path lengths.
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • No TBD_T092 left.
  • k2d world and Gazebo map align within one cell (test comparing occupancy).
  • Map IoU ≥ 0.95 between k2d and Gazebo maps.
  • Nominal path length equal within ± 2 % across backends.
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • tests/unit/scenario/test_map_alignment.py.

Dependencies

Blocked by: #190 (T-091)

Blocks: #196 (T-094a)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • configs/maps/**
  • tasks/warehouse_delivery_v1.yaml (poses)
  • docs/evidence/T-092.md

Independent.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-092 (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 06 §1 · doc 06 §7 · doc 10 §7.1

Requirements: FR-SIM-003 · FR-SCN-002 (traceability: doc 28)

External:

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:rosROS 2 nodes and packagesarea:scenarioScenario space, sampling, scenario filesmilestone:M9M9 — Gazebo backendpriority:P0Critical path / blocks otherssize:S<= 1 daytaskChild task of a milestone epictype:researchTime-boxed spike / investigation

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions