Skip to content

[T-091] Verify & record ROS topics, frames, param names, lidar plane and pallet height → topics.yaml and task file #190

Closed

Description

@CodewithJha

Task T-091 · Milestone M9 — Gazebo backend · Size S · Priority P0 · Epic #9

Implements FR-SIM-003

Branch spike/t-091-verify-record-ros-topics-frames — one task = one branch = one PR (doc 32 §6)

Summary

Against the pinned packages, record exact topic names/types (incl. TwistStamped cmd_vel when enable_stamped_cmd_vel), TF frames, bridge entries, lidar mount height, depth camera topic, Nav2 controller param paths (MPPI vx_max / DWB max_vel_x, velocity smoother) and pallet model dimensions into ros_ws/src/roboprobe_ros/config/topics.yaml, the TB4 SUT profile and tasks/warehouse_delivery_v1.yaml.

Context / motivation

Doc 10 §3: code reads topic names from this file, never literals; every TBD_T091 marker must be resolved.

Scope

In scope

  • Script scripts/ros_introspect.sh that dumps ros2 topic list -t, ros2 param dump into docs/evidence/T-091/ for reproducibility.

Implementation guidance

  • In the T-090 container run scripts/ros_introspect.sh, which captures ros2 topic list -t; ros2 topic info -v for scan/depth/cmd_vel/odom/amcl_pose/ground-truth topics; ros2 param dump for controller_server, velocity_smoother, local_costmap, global_costmap, amcl, bt_navigator; the TF frame list (tf2_tools view_frames); gz topic -l; the TB4 SDF sensor poses (lidar height) and the pallet model dimensions.
  • topics.yaml schema: {topics: {scan_raw: {name, type, qos}, scan, depth_points_raw, depth_points, cmd_vel_nav, cmd_vel, odom, amcl_pose, ground_truth_pose, bt_log}, frames: {map, odom, base_link, laser}, stamped_cmd_vel: bool}, validated by schemas/ros_topics.schema.json, used by both the ROS package and the Python backend.
  • Update SUT profile speed_param_paths (e.g. controller_server.ros__parameters.FollowPath.vx_max for MPPI) and the lidar/pallet constants in tasks/warehouse_delivery_v1.yaml, replacing every TBD_T091.
  • Add the CI grep step ! grep -R "TBD_T091" --exclude-dir=.git . to the lint job (append-only).
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • No TBD_T091 left in the repo (CI grep).
  • Evidence dump committed.
  • topics.yaml validates against the new schema in CI.
  • Evidence dump reproducible by re-running the script.
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • CI grep check for TBD_T091.
  • Schema validation test tests/unit/backends/gazebo/test_topics_schema.py.

Dependencies

Blocked by: #58 (T-090)

Blocks: #191 (T-092), #192 (T-093a), #201 (T-096a)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • ros_ws/src/roboprobe_ros/config/topics.yaml
  • configs/sut_profiles/tb4_nav2_default.yaml
  • tasks/warehouse_delivery_v1.yaml
  • scripts/ros_introspect.sh
  • docs/evidence/T-091/**

Independent of backend code.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-091 (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 10 §3 · doc 06 §7 · doc 10 §4

Requirements: FR-SIM-003 (traceability: doc 28)

External:

Activity

  1. added
    type:researchTime-boxed spike / investigation
    area:simulatorSimulator backends (kinematic2d, Gazebo adapter)
    area:rosROS 2 nodes and packages
    priority:P0Critical path / blocks others
    taskChild task of a milestone epic
    on Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:rosROS 2 nodes and packagesarea:simulatorSimulator backends (kinematic2d, Gazebo adapter)milestone:M9M9 — Gazebo backendpriority:P0Critical path / blocks otherssize:S<= 1 daytaskChild task of a milestone epictype:researchTime-boxed spike / investigation

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions