Skip to content

[T-093a] roboprobe_ros ament_python package skeleton: package.xml, setup, params loading from topics.yaml, vendored geometry #192

Closed

Description

@CodewithJha

Task T-093a · Milestone M9 — Gazebo backend · Size S · Priority P0 · Epic #9

Implements FR-SIM-003

Branch chore/t-093a-ament-python-package-skeleton-package — one task = one branch = one PR (doc 32 §6)

Summary

Create ros_ws/src/roboprobe_ros/ per doc 16 §5: ament_python package, node base class reading topic names/QoS from config/topics.yaml and parameters from perturb_params.yaml, per-node seeded RNG, structured logging, and a vendoring script copying roboprobe.geometry/perturbation pure modules (checked for drift in CI).

Context / motivation

Shared base for all ROS nodes; vendoring keeps oracles backend-independent (doc 10 §6).

Scope

In scope

  • colcon build + colcon test in CI container (job added in T-098).

Implementation guidance

  • Layout (doc 16 §5): ros_ws/src/roboprobe_ros/{package.xml, setup.py, setup.cfg, resource/roboprobe_ros, roboprobe_ros/__init__.py, roboprobe_ros/base.py, config/topics.yaml, launch/, test/}; package.xml format 3 with exec_depend on rclpy, sensor_msgs, geometry_msgs, nav_msgs, nav2_msgs, sensor_msgs_py, python3-numpy, python3-pyarrow.
  • base.py: class RoboProbeNode(rclpy.node.Node) loading topics.yaml (param topics_file) and perturb_params.yaml (param perturb_file), exposing self.topic(name), self.qos(name), self.rng (numpy.random.Generator(PCG64(seed)) from a seed param) and JSON logging so episode logs parse like backend logs.
  • Vendoring: scripts/vendor_geometry.py copies backend/src/roboprobe/geometry/*.py and perturbation/*.py into roboprobe_ros/_vendor/ with a header comment and a SHA-256 manifest; a CI job compares hashes and fails on drift. Vendored modules stay pure numpy (guaranteed by the layering rules).
  • Lint with ruff using the backend configuration (doc 16 §5).
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • Package builds; drift check fails if vendored modules differ from source.
  • colcon build --packages-select roboprobe_ros and colcon test succeed in the Jazzy container.
  • Vendoring drift check fails when a source module changes without re-vendoring (test).
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • ros_ws/src/roboprobe_ros/test/test_base.py (pytest under colcon).

Dependencies

Blocked by: #190 (T-091), #43 (T-030a)

Blocks: #193 (T-093b), #194 (T-093c), #195 (T-093d), #196 (T-094a), #197 (T-094b), #198 (T-094c)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • ros_ws/src/roboprobe_ros/package.xml
  • ros_ws/src/roboprobe_ros/setup.py
  • ros_ws/src/roboprobe_ros/roboprobe_ros/base.py
  • ros_ws/src/roboprobe_ros/roboprobe_ros/_vendor/**
  • scripts/vendor_geometry.py

Interface for T-093b–d / T-094a–c.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-093a (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 16 §5 · doc 10 §6 · doc 10 §3

Requirements: FR-SIM-003 (traceability: doc 28)

External:

Activity

  1. added
    type:choreMaintenance / scaffolding
    area:rosROS 2 nodes and packages
    priority:P0Critical path / blocks others
    taskChild task of a milestone epic
    on Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:rosROS 2 nodes and packagesmilestone:M9M9 — Gazebo backendpriority:P0Critical path / blocks otherssize:S<= 1 daytaskChild task of a milestone epictype:choreMaintenance / scaffolding

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions