p2p: export bootstrap sync-progress accessors - #130
Open
moralpriest wants to merge 1 commit into
Open
Conversation
GetSyncProgress and IsBootstrapActive expose the progress state that bootstrap_chain already maintains (package-private sync_progress), so external consumers such as wallet UIs can render real chunk-level bootstrap progress instead of guessing from block height. Pure addition: read-only access to existing fields.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the bootstrap progress state that
bootstrap_chain()already tracks (p2p/chain_bootstrap.go), which is currently package-private.What
GetSyncProgress()returns the currentstate.Height,state.Chunk,state.StepIsBootstrapActive()reports whether a bootstrap is in flightWhy
External consumers have no way to render real bootstrap progress today — block height alone is misleading during tree downloads. Wallet UIs (e.g. TUI wallets) need chunk-level visibility to show honest progress bars.
Pure addition: read-only access to existing fields, zero behavior change, no new dependencies.
Originated during review of #59; shipping separately as agreed there since it's independent of the pipelining work.