Feat/pipeline parallelize fastsync - #59
Open
secretnamebasis wants to merge 6 commits into
Open
Conversation
|
Great work — I've been running this pipelined fastsync against mainnet: ~26–28 MB/min sustained vs ~2–3 MB/min serial on the same link. I built a wallet-TUI progress consumer on top of it and needed visibility into the pipeline state, plus better window scaling on many-core machines. Opened a small follow-up PR stacked on this branch (+21/−2,
Branch also at |
Author
|
@moralpriest thank you for the feedback and the pr on the base branch. |
|
Opened a separate PR for the progress accessors per this discussion: #130 |
The balance-tree loop and the nested per-SC data-tree fetches were already pipelined, but the SC-meta tree's own outer loop still issued one blocking Peer.TreeSection call per chunk - caught live by watching a real bootstrap run, where step 2 progressed noticeably slower than step 1 per unit of work. Fire outer chunk requests ahead using the same fire()/drain-by- completion pattern as the balance tree, but cap the outer window at 4 (a separate, smaller budget than the nested per-SC pipeline) so the two concurrency layers don't compound against the single peer being used - each outer chunk still spins up its own nested per-SC pipeline below, so an unbounded outer window would multiply, not just add to, total in-flight requests.
Same cleanup as applied to feat/torrent-and-pipeline-merge: drops
internal planning-narrative framing ("caught live", "flagged early
on") from the SC-meta pipelining comment, keeping the technical why.
No behavior change.
Same fix as on feat/torrent-and-pipeline-merge: bootstrap_chain() writes topo-store placeholder entries with BLOCK_ID=zerohash but a non-zero State_Version, which TopoRecord.IsClean() treats as "not clean" - so while bootstrap is mid-write, Get_Top_ID() can return the zero hash literally, and fill_common's ReadBlockSnapshotVersion lookup on that hash panics (maps to a shard directory that legitimately never exists). Treat a zero Get_Top_ID() as "chain not ready yet" and skip the lookup instead of panicking. Same signature, no call-site changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bootstrap_chain()'s--fastsyncstate-tree fetch (both the balance-tree phase and the smart-contract-tree phase) fetched onePeer.TreeSectionchunk at a time, waiting for each round-trip before requesting the next. This PR pipelines both phases: up to 16 concurrentPeer.TreeSectionrequests are in flight at once, with results drained in completion order rather than strict index order.Draining in completion order also fixes a real bug in a naive "just add concurrency" approach: waiting on requests in strict index order means one slow chunk head-of-line-blocks visibility into other chunks that already finished, which mostly cancels out the benefit of firing them concurrently in the first place. Chunk writes are commutative (each writes a disjoint key range into the same tree), so there's no ordering requirement — only the resume checkpoint needs to stay correct, which is now tracked via a low-water-mark instead of the last-fired index.
Only the network round-trips (
connection.Client.Call) run inside worker goroutines. AllgravitonTree/Snapshotreads and writes (GetTree,Put,Commit) stay on the single calling goroutine as results are drained — there is no concurrent access togravitonobjects at any point, since that thread-safety was never something I could verify.Live-tested against a real mainnet peer:
Fixes # (issue)
Type of change
Which part is impacted?
Checklist:
License
I am contributing & releasing the code under DERO Research License (which can be found here).