Integrate dexsim gizmo controllers - #431
Open
yuecideng wants to merge 1 commit into
Open
Conversation
Delegate entity and robot gizmo control to dexsim, wire entity gizmos into viewer lifecycle, and exclude the default plane from manipulation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
EntityGizmoManipulator.default_planeas a static external target so it cannot be manipulated.IKGizmoControllerandNewtonChainIK, while adapting joint state reads and writes through EmbodiChain'sRobotabstraction.Dependency / merge gate
This PR requires the next dexsim release and must not be merged or released before that version is published and EmbodiChain's dexsim requirement is updated.
The required dexsim release must include:
World.enable_entity_gizmo(),World.disable_entity_gizmo(), andWorld.get_entity_gizmo();EntityGizmoManipulatorsupport, includingregister_external_target();dexsim.kit.ik.IKGizmoControlleranddexsim.kit.ik.NewtonChainIK.The dependency file is intentionally unchanged because that dexsim version has not been released yet.
Related: #420
Type of change
Screenshots
Not applicable; behavior is covered by automated tests and interactive dexsim smoke tests.
Validation
black .git diff --checkpython -m compileallon changed Python modulespytest -q tests/sim/test_cfg.py tests/sim/test_sim_manager.py tests/sim/objects/test_gizmo.py— 28 passedpytest -q tests/sim/objects/test_robot_cfg.py -k 'not pk_dof'— 20 passedpytest -q tests/sim/objects/test_robot_cfg.py -k 'pk_dof'— 8 passedChecklist
black .command to format the code base.