Skip to content

Support physics and render configs in gym configuration - #433

Merged
yuecideng merged 1 commit into
mainfrom
enhance/gym-physics-render-config
Jul 28, 2026
Merged

Support physics and render configs in gym configuration#433
yuecideng merged 1 commit into
mainfrom
enhance/gym-physics-render-config

Conversation

@yuecideng

Copy link
Copy Markdown
Contributor

Description

This PR simplifies PhysicsCfg by removing four solver implementation options from the public configuration while retaining their established DexSim defaults.

It also adds top-level physics_config and render_cfg parsing to gym JSON/YAML files. Launcher-provided renderer values remain explicit overrides, while an omitted --renderer now preserves render_cfg.renderer.

The configuration guide and simulation manager documentation include the updated public surface and file-based configuration example.

Dependencies: None.

Issue: No issue linked.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Not applicable.

Testing

  • pytest tests -q: 797 passed, 103 skipped
  • pytest tests/sim/test_cfg.py tests/gym/utils/test_gym_utils.py -q: 30 passed
  • Black passes for all files included in this PR
  • git diff --check passes

The strict Sphinx -W build was attempted and reached the project-wide pre-existing documentation warnings/errors; no new warning was identified in the changed pages.

Checklist

  • I have run Black to format the changed Python files.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove the change works.
  • Dependencies are unchanged.

Parse PhysicsCfg and RenderCfg from gym JSON/YAML files while preserving explicit CLI renderer overrides. Simplify PhysicsCfg by fixing internal solver options to their established defaults.
Copilot AI review requested due to automatic review settings July 28, 2026 12:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@yuecideng yuecideng added enhancement New feature or request gym robot learning env and its related features physics Things related to physics rendering Things related to rendering (eg, performace, efficiency, bug) labels Jul 28, 2026
@yuecideng
yuecideng merged commit fd8e43d into main Jul 28, 2026
4 checks passed
@yuecideng
yuecideng deleted the enhance/gym-physics-render-config branch July 28, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gym robot learning env and its related features physics Things related to physics rendering Things related to rendering (eg, performace, efficiency, bug)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants