Support physics and render configs in gym configuration - #433
Merged
Conversation
Parse PhysicsCfg and RenderCfg from gym JSON/YAML files while preserving explicit CLI renderer overrides. Simplify PhysicsCfg by fixing internal solver options to their established defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies
PhysicsCfgby removing four solver implementation options from the public configuration while retaining their established DexSim defaults.It also adds top-level
physics_configandrender_cfgparsing to gym JSON/YAML files. Launcher-provided renderer values remain explicit overrides, while an omitted--renderernow preservesrender_cfg.renderer.The configuration guide and simulation manager documentation include the updated public surface and file-based configuration example.
Dependencies: None.
Issue: No issue linked.
Type of change
Screenshots
Not applicable.
Testing
pytest tests -q: 797 passed, 103 skippedpytest tests/sim/test_cfg.py tests/gym/utils/test_gym_utils.py -q: 30 passedgit diff --checkpassesThe strict Sphinx
-Wbuild was attempted and reached the project-wide pre-existing documentation warnings/errors; no new warning was identified in the changed pages.Checklist