Repository navigation
Follow public-directory symlinks and warn on traversal errors - #5897
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this time,
dx build --webcan finish successfully while linked files in[application].public_dirare missing. The directory walk does not follow links, so its regular-file filter drops symlink entries.This follows WalkDir's link traversal while retaining each entry's public-relative path, including links to targets outside the directory. Broken links, directory loops, and traversal read errors warn with their path and remain nonfatal, while an absent public directory stays silent. Linux regression tests and a CLI build cover linked files, linked directories, and continued copying after traversal errors.
Public-directory optimization is separate work in #5651 and #5678. Related symlink work covers
asset!path resolution in #3422 and macOS framework bundles in #5879 and #5880.