Repository navigation
Give the Dioxus example a web app manifest and icons - #11
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LucaCappelletti94
force-pushed
the
d1-dioxus
branch
from
October 7, 2026 23:55
92a7bde to
2efeaf4
Compare
LucaCappelletti94
force-pushed
the
d1-dioxus
branch
from
October 8, 2026 00:45
2efeaf4 to
a34e8cb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## s1-traits #11 +/- ##
=============================================
+ Coverage 91.78% 91.83% +0.04%
=============================================
Files 33 33
Lines 2824 2841 +17
Branches 37 37
=============================================
+ Hits 2592 2609 +17
Misses 205 205
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
d1-dioxus
branch
from
October 8, 2026 01:53
a34e8cb to
c0f14f7
Compare
LucaCappelletti94
force-pushed
the
d1-dioxus
branch
2 times, most recently
from
October 8, 2026 14:46
c461470 to
c6720e8
Compare
LucaCappelletti94
force-pushed
the
d1-dioxus
branch
from
October 8, 2026 16:42
c6720e8 to
a9311dc
Compare
LucaCappelletti94
force-pushed
the
d1-dioxus
branch
from
October 9, 2026 01:46
a9311dc to
641ebd7
Compare
LucaCappelletti94
force-pushed
the
d1-dioxus
branch
from
October 9, 2026 03:32
641ebd7 to
7737f4e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



A Dioxus app had to point
dxinto this crate's sources for the Android module and the static service worker, which no app using the published crate can do. The newdioxusfeature declares both inside the crate, sodxbundles the module and serves the worker from the app's assets, and the example drops its own glue.With the worker out of
public_dir, the example ships the web app manifest and icons #6 was waiting on without needing DioxusLabs/dioxus#5897. The feature needs the Rust version Dioxus 0.7 apps already need, so the MSRV job leaves it out.