Skip to content

Give the Dioxus example a web app manifest and icons - #11

Merged
LucaCappelletti94 merged 3 commits into
s1-traitsfrom
d1-dioxus
Oct 10, 2026
Merged

LucaCappelletti94 merged 3 commits into
s1-traitsfrom
d1-dioxus

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Owner

A Dioxus app had to point dx into this crate's sources for the Android module and the static service worker, which no app using the published crate can do. The new dioxus feature declares both inside the crate, so dx bundles the module and serves the worker from the app's assets, and the example drops its own glue.

With the worker out of public_dir, the example ships the web app manifest and icons #6 was waiting on without needing DioxusLabs/dioxus#5897. The feature needs the Rust version Dioxus 0.7 apps already need, so the MSRV job leaves it out.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 56c8f7ac-40d3-4828-ad3b-3c4692dc9b15

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.83%. Comparing base (a31ae4b) to head (7737f4e).

Additional details and impacted files
@@              Coverage Diff              @@
##           s1-traits      #11      +/-   ##
=============================================
+ Coverage      91.78%   91.83%   +0.04%     
=============================================
  Files             33       33              
  Lines           2824     2841      +17     
  Branches          37       37              
=============================================
+ Hits            2592     2609      +17     
  Misses           205      205              
  Partials          27       27              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@LucaCappelletti94
LucaCappelletti94 merged commit 8c15151 into main Oct 10, 2026
40 of 59 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the d1-dioxus branch October 10, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant