ENG-1976 Add schema export command to Obsidian by trangdoan982 · Pull Request #1263 · DiscourseGraphs/discourse-graph

trangdoan982 · 2026-07-29T02:40:12Z

https://www.loom.com/share/38ffe52d5c5e410282e962079103513d

https://www.loom.com/share/45b49cc16d7b498482643edcc68e4a4c

Summary

Adds the schema export command and settings entry point.

specExport.ts — serializes the vault's selected node types, relation types, relation triples, and templates into the DiscourseSchemaFile JSON format
ExportSpecsModal.tsx — modal that renders SchemaSelectionModalBody + SchemaSelectionPanel; user selects items to export then saves to a filesystem location via the native save dialog
GeneralSettings.tsx — adds "Export discourse graph schema" entry to the settings UI
registerCommands.ts — registers export-dg-schema command in the command palette

Populating `vaultId`

specExport.ts fills vaultId from the vault's Obsidian appId via getVaultId(plugin.app).

The field itself — the type and the Zod validation — is defined in #1180, since it is part of the schema file contract. This PR only populates it. The reason it exists: vaultName is not unique across vaults, so it cannot identify a source space; vaultId lets the importer in #1264 rebuild the source RID as orn:obsidian.schema:<appId>/<localId>, matching what the existing Supabase import path generates.

Stack

PR 3 of 5 for FEE-840. Stacks on #1262.

Shared foundation — ENG-1975 (ENG-1975 Define schema file contract and shared foundation for Obsidian export/import #1180)
Schema selection panel UI — ENG-2083 (ENG-2083 Add schema selection panel UI for Obsidian export/import #1262)
This PR — schema export command (ENG-1976)
Schema import data layer (ENG-1977) — ENG-1977 Add schema import data layer for Obsidian #1264
Schema import UI (ENG-2084) — ENG-2084 Add schema import UI for Obsidian #1265

Test plan

pnpm --filter @discourse-graphs/obsidian check-types passes
Command palette: Export discourse graph schema opens the export modal
Settings entry opens the export modal
Dependency enforcement: selecting a triple locks its source/dest node types and relation type
Export saves a valid dg-schema-<vault>.json to the chosen filesystem location
Exported JSON contains the selected node types, relation types, triples, and templates
Exported JSON contains a non-empty vaultId matching the vault's appId
Two vaults sharing a vaultName produce different vaultId values

linear-code · 2026-07-29T02:40:15Z

ENG-1976

supabase · 2026-07-29T02:40:17Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

vercel · 2026-07-29T02:40:18Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Ready	Preview	Jul 30, 2026 6:12pm

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

graphite-app · 2026-07-30T16:56:29Z

PR size/scope check

This PR is over our review-size guideline.

Recommended: ~200 lines changed
Acceptable limit: up to 400 lines when well-scoped/self-contained
Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

What single problem this PR solves
Why the files/changes are coupled

…otModal abstraction)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…csModal constructor, fix type guard, batch warnings - specExport.ts: drop SpecExportSelection, import SchemaSelection from ~/types; add type guard on selectedRelationTypes - ExportSpecsModal.tsx: constructor takes only plugin (extracts app internally); remove plugin.app from useMemo deps; pass payload directly to exportSchemaSelection; batch warnings into one Notice - registerCommands.ts: simplify callback to single expression - GeneralSettings.tsx: remove redundant void cast Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…rectly Replace asMap + map + filter with Set membership filter over settings arrays. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ifetime Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ortSchemaSelection Removes SpecExportResult and buildSchemaExportPayload; exportSchemaSelection now returns Promise<string> and surfaces warnings via onWarning callback, eliminating the three-hop pass-through. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The field is part of the schema file contract defined in ENG-1975; this fills it from the vault's appId so importers can rebuild the source RID. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

This was referenced Jul 29, 2026

ENG-1977 Add schema import data layer for Obsidian #1264

Open

ENG-2084 Add schema import UI for Obsidian #1265

Open

FEE-840 Add schema export for Obsidian #1163

Closed

FEE-840 Add schema import for Obsidian #1164

Closed

devin-ai-integration Bot reviewed Jul 29, 2026

View reviewed changes

trangdoan982 force-pushed the eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport branch 2 times, most recently from f8e4b8d to e9132f3 Compare July 29, 2026 02:58

trangdoan982 force-pushed the eng-1976-add-schema-export-command-to-obsidian branch from 3af9adf to f364d5a Compare July 29, 2026 02:58

vercel Bot temporarily deployed to Preview July 29, 2026 02:58 Inactive

trangdoan982 force-pushed the eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport branch from e9132f3 to 6eefcca Compare July 29, 2026 19:45

trangdoan982 force-pushed the eng-1976-add-schema-export-command-to-obsidian branch from f364d5a to 09bb0e7 Compare July 29, 2026 19:45

vercel Bot deployed to Preview July 29, 2026 19:46 View deployment

vercel Bot temporarily deployed to Preview July 30, 2026 02:17 Inactive

trangdoan982 force-pushed the eng-1976-add-schema-export-command-to-obsidian branch from 5119839 to cfff9bf Compare July 30, 2026 03:18

vercel Bot temporarily deployed to Preview July 30, 2026 03:18 Inactive

trangdoan982 force-pushed the eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport branch from bc97511 to 55f5f58 Compare July 30, 2026 16:54

trangdoan982 changed the base branch from eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport to main July 30, 2026 16:56

trangdoan982 changed the base branch from main to eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport July 30, 2026 16:56

trangdoan982 force-pushed the eng-1976-add-schema-export-command-to-obsidian branch from cfff9bf to 3820532 Compare July 30, 2026 17:01

vercel Bot temporarily deployed to Preview July 30, 2026 17:01 Inactive

vercel Bot temporarily deployed to Preview July 30, 2026 17:06 Inactive

vercel Bot temporarily deployed to Preview July 30, 2026 17:16 Inactive

vercel Bot temporarily deployed to Preview July 30, 2026 17:55 Inactive

trangdoan982 added 3 commits July 30, 2026 14:06

ENG-1976 Add schema export command to Obsidian

c64b70d

ENG-1976 Inline Modal boilerplate in ExportSpecsModal (remove ReactRo…

b437189

…otModal abstraction)

ENG-1976 Remove console.error (violates Obsidian plugin guidelines)

e97671b

trangdoan982 and others added 6 commits July 30, 2026 14:06

ENG-1976 Remove emptyTemplateText prop from ExportSpecsModal call site

fbf3e3f

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ENG-1976 Simplify buildSchemaExportPayload: filter settings arrays di…

e9917e0

…rectly Replace asMap + map + filter with Set membership filter over settings arrays. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ENG-1976 Remove useMemo from source — settings are stable for modal l…

944257b

…ifetime Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ENG-1976 Populate vaultId in the exported schema payload

83e0548

The field is part of the schema file contract defined in ENG-1975; this fills it from the vault's appId so importers can rebuild the source RID. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

trangdoan982 mentioned this pull request Jul 30, 2026

ENG-1975 Define schema file contract and shared foundation for Obsidian export/import #1180

Open

5 tasks

trangdoan982 force-pushed the eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimport branch from 55f5f58 to 07ccd44 Compare July 30, 2026 18:12

trangdoan982 force-pushed the eng-1976-add-schema-export-command-to-obsidian branch from 31a387c to 83e0548 Compare July 30, 2026 18:12

vercel Bot deployed to Preview July 30, 2026 18:12 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ENG-1976 Add schema export command to Obsidian - #1263

ENG-1976 Add schema export command to Obsidian#1263
trangdoan982 wants to merge 9 commits into
eng-2083-add-schema-selection-panel-ui-for-obsidian-exportimportfrom
eng-1976-add-schema-export-command-to-obsidian

trangdoan982 commented Jul 29, 2026 •

edited

Loading

Uh oh!

linear-code Bot commented Jul 29, 2026

Uh oh!

supabase Bot commented Jul 29, 2026

Uh oh!

vercel Bot commented Jul 29, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

graphite-app Bot commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

trangdoan982 commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Populating vaultId

Stack

Test plan

Uh oh!

linear-code Bot commented Jul 29, 2026

Uh oh!

supabase Bot commented Jul 29, 2026

Uh oh!

vercel Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

graphite-app Bot commented Jul 30, 2026

PR size/scope check

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

trangdoan982 commented Jul 29, 2026 •

edited

Loading

Populating `vaultId`

vercel Bot commented Jul 29, 2026 •

edited

Loading