ENG-2084 Add schema import UI for Obsidian by trangdoan982 · Pull Request #1265 · DiscourseGraphs/discourse-graph

trangdoan982 · 2026-07-29T02:40:35Z

https://www.loom.com/share/477c5ed1d52442139ea4f6c99af47936

Summary

Adds the import modal UI and wires it into the command palette and settings.

ImportSchemaPreviewSummary.tsx — per-category new/existing counts shown before the user applies the import
ImportSpecsModal.tsx — two-screen modal: file picker screen → preview + selection screen (reuses SchemaSelectionModalBody + SchemaSelectionPanel from ENG-2083); delegates apply logic to applySchemaImportSelection from ENG-1977
GeneralSettings.tsx — adds "Import discourse graph schema" entry to the settings UI
registerCommands.ts — registers import-dg-schema command in the command palette

Stack

PR 5 of 5 for FEE-840. Stacks on #1264.

Shared foundation — ENG-1975 (ENG-1975 Define schema file contract and shared foundation for Obsidian export/import #1180)
Schema selection panel UI — ENG-2083 (ENG-2083 Add schema selection panel UI for Obsidian export/import #1262)
Schema export command — ENG-1976 (ENG-1976 Add schema export command to Obsidian #1263)
Schema import data layer — ENG-1977 (ENG-1977 Add schema import data layer for Obsidian #1264)
This PR — schema import UI (ENG-2084)

Test plan

pnpm --filter @discourse-graphs/obsidian check-types passes
Command palette: Import discourse graph schema opens the import modal
Settings entry opens the import modal
Picking a non-schema JSON or wrong-version file shows a clear error notice
Preview summary shows correct new/existing counts per category
Selection panel enforces dependency constraints
Import applies correctly and creates new items as provisional
Re-importing the same file creates no duplicates

linear-code · 2026-07-29T02:40:38Z

ENG-2084

vercel · 2026-07-29T02:40:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Skipped		Jul 30, 2026 8:27pm

supabase · 2026-07-29T02:40:42Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

…otModal abstraction)

…hemaPreviewSummary as sibling Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…chemaSelection directly, batch warnings - Constructor takes only plugin (extracts app internally), matching ExportSpecsModal pattern - Pass payload directly to applySchemaImportSelection (no intermediate field mapping) - Batch import warnings into one Notice Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…nent lifetime Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Import stays reachable through the import-dg-schema command in the palette; the settings entry duplicated it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

The success path calls onClose() and unmounts, so the finally block was setting state on an unmounted component. Harmless — React removed that warning in 18.0 and it is a silent no-op — but the ordering read as if the reset mattered after close. Only the catch stays mounted, so only it resets. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

This was referenced Jul 29, 2026

FEE-840 Add schema export for Obsidian #1163

Closed

FEE-840 Add schema import for Obsidian #1164

Closed

devin-ai-integration Bot reviewed Jul 29, 2026

View reviewed changes

trangdoan982 force-pushed the eng-1977-add-schema-import-command-to-obsidian branch from 23c69c1 to d417d43 Compare July 29, 2026 02:59

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from 11d1480 to 5f5edc0 Compare July 29, 2026 02:59

vercel Bot temporarily deployed to Preview July 29, 2026 02:59 Inactive

trangdoan982 force-pushed the eng-1977-add-schema-import-command-to-obsidian branch from d417d43 to bc0e07d Compare July 29, 2026 19:45

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from 5f5edc0 to ce3af53 Compare July 29, 2026 19:45

vercel Bot temporarily deployed to Preview July 29, 2026 19:45 Inactive

vercel Bot temporarily deployed to Preview July 29, 2026 22:32 Inactive

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from 2db3e8e to 1fc3e89 Compare July 30, 2026 02:17

trangdoan982 force-pushed the eng-1977-add-schema-import-command-to-obsidian branch from bc0e07d to 34254ad Compare July 30, 2026 02:17

vercel Bot temporarily deployed to Preview July 30, 2026 02:17 Inactive

graphite-app Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread apps/obsidian/src/components/ImportSpecsModal.tsx

trangdoan982 force-pushed the eng-1977-add-schema-import-command-to-obsidian branch from 34254ad to 9073b20 Compare July 30, 2026 03:18

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from 1fc3e89 to c731999 Compare July 30, 2026 03:18

vercel Bot temporarily deployed to Preview July 30, 2026 03:18 Inactive

trangdoan982 force-pushed the eng-1977-add-schema-import-command-to-obsidian branch from 9073b20 to 26d1ad2 Compare July 30, 2026 17:01

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from c731999 to f8c8b70 Compare July 30, 2026 17:01

vercel Bot temporarily deployed to Preview July 30, 2026 17:01 Inactive

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from f8c8b70 to 20506b2 Compare July 30, 2026 17:06

vercel Bot temporarily deployed to Preview July 30, 2026 17:06 Inactive

trangdoan982 force-pushed the eng-1977-add-schema-import-command-to-obsidian branch from 26d1ad2 to 6b684dc Compare July 30, 2026 17:06

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from 20506b2 to ab0552c Compare July 30, 2026 17:18

vercel Bot temporarily deployed to Preview July 30, 2026 17:18 Inactive

trangdoan982 force-pushed the eng-1977-add-schema-import-command-to-obsidian branch from b0abbd4 to 2a39a08 Compare July 30, 2026 17:55

trangdoan982 mentioned this pull request Jul 30, 2026

ENG-1977 Add schema import data layer for Obsidian #1264

Open

6 tasks

This was referenced Jul 30, 2026

ENG-1975 Define schema file contract and shared foundation for Obsidian export/import #1180

Open

ENG-1976 Add schema export command to Obsidian #1263

Open

trangdoan982 force-pushed the eng-1977-add-schema-import-command-to-obsidian branch from 2a39a08 to 2f98215 Compare July 30, 2026 18:12

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from ab0552c to 6de77ff Compare July 30, 2026 18:12

vercel Bot temporarily deployed to Preview July 30, 2026 18:12 Inactive

trangdoan982 and others added 8 commits July 30, 2026 14:37

ENG-2084 Add schema import UI for Obsidian

aeac259

ENG-2084 Inline Modal boilerplate in ImportSpecsModal (remove ReactRo…

5105e04

…otModal abstraction)

ENG-2084 Show human-readable error when schema file fails Zod validation

044c346

ENG-2084 Remove console.error (violates Obsidian plugin guidelines)

3326453

ENG-2084 Remove emptyTemplateText/beforePanel props; compose ImportSc…

de4f384

…hemaPreviewSummary as sibling Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ENG-2084 Remove useMemo from source — schema file is stable for compo…

cd7e537

…nent lifetime Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ENG-2084 Use onWarning callback in applySchemaImportSelection

69deb70

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

trangdoan982 force-pushed the eng-2084-add-schema-import-ui-for-obsidian branch from 6de77ff to 69deb70 Compare July 30, 2026 18:37

vercel Bot temporarily deployed to Preview July 30, 2026 18:37 Inactive

ENG-2084 Drop schema import entry from settings

f8d4c97

Import stays reachable through the import-dg-schema command in the palette; the settings entry duplicated it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

vercel Bot temporarily deployed to Preview July 30, 2026 20:23 Inactive

vercel Bot temporarily deployed to Preview July 30, 2026 20:27 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ENG-2084 Add schema import UI for Obsidian - #1265

ENG-2084 Add schema import UI for Obsidian#1265
trangdoan982 wants to merge 10 commits into
eng-1977-add-schema-import-command-to-obsidianfrom
eng-2084-add-schema-import-ui-for-obsidian

trangdoan982 commented Jul 29, 2026 •

edited

Loading

Uh oh!

linear-code Bot commented Jul 29, 2026

Uh oh!

vercel Bot commented Jul 29, 2026 •

edited

Loading

Uh oh!

supabase Bot commented Jul 29, 2026

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

trangdoan982 commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Stack

Test plan

Uh oh!

linear-code Bot commented Jul 29, 2026

Uh oh!

vercel Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase Bot commented Jul 29, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

trangdoan982 commented Jul 29, 2026 •

edited

Loading

vercel Bot commented Jul 29, 2026 •

edited

Loading