Skip to content

macro.my.id / verify: prefix verification TXT value (v2) - #3215

Closed
mbayue wants to merge 2 commits into
Domain-Connect:masterfrom
mbayue:macro-verify-token-prefix
Closed

mbayue wants to merge 2 commits into
Domain-Connect:masterfrom
mbayue:macro-verify-token-prefix

Conversation

@mbayue

@mbayue mbayue commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Follow-up hardening for the macro.my.id / verify template.

Cloudflare suggested constraining the TXT value so a malicious link cannot write an arbitrary value at _macro-verify. This changes the record data from %token% to macro-verify=%token% and bumps the template version to 2.

Notes:

  • The currently onboarded v1 template remains live until this is merged/re-onboarded; no immediate provider-side change is implied by opening this PR.
  • Verification logic should look for the current token among the values at _macro-verify (each application adds a new record).

The public signing key format issue from the onboarding thread has been fixed separately by splitting the TXT record into p=1/p=2 chunks.

@github-actions github-actions Bot added the Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. label Nov 19, 2026
@github-actions

Copy link
Copy Markdown

✅ JSON Filename Check Passed

@github-actions github-actions Bot added the PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. label Nov 19, 2026
@github-actions

Copy link
Copy Markdown

✅ JSON Schema Validation Passed

@github-actions github-actions Bot added the Test links missing No test links from Online Editor provided label Nov 19, 2026
@github-actions

Copy link
Copy Markdown

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details

Labels to add: Checklist of common problems not complete, PR description incomplete, Test links missing
Labels to remove: Forged editor links

PR description check FAILED:
  FAIL  'Type of change' section not found
  FAIL  'How Has This Been Tested?' section not found
  FAIL  'Checklist of common problems' section not found
  FAIL  'Online Editor test results' section not found
  FAIL  Template coverage: macro.my.id.verify.json: no editor test link found (expected template id 'macro.my.id.verify')

@github-actions

Copy link
Copy Markdown

Linter OK

macro.my.id.verify.json

Level Code Note

@github-actions github-actions Bot added the automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. label Nov 19, 2026
@mbayue

mbayue commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #3216 — this branch was created before the v1 template was merged upstream, so it showed an add/add conflict. The replacement PR is based on current master.

@mbayue mbayue closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant