Repository navigation
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
Linter OK
|
| Level | Code | Note |
|---|
14 tasks done
Contributor
Author
|
Closing in favor of #3216 — this branch was created before the v1 template was merged upstream, so it showed an add/add conflict. The replacement PR is based on current master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up hardening for the
macro.my.id / verifytemplate.Cloudflare suggested constraining the TXT value so a malicious link cannot write an arbitrary value at
_macro-verify. This changes the record data from%token%tomacro-verify=%token%and bumps the template version to 2.Notes:
_macro-verify(each application adds a new record).The public signing key format issue from the onboarding thread has been fixed separately by splitting the TXT record into
p=1/p=2chunks.