Repository navigation
Conversation
|
✅ JSON Filename Check Passed |
Linter OK
|
| Level | Code | Note |
|---|
|
✅ JSON Schema Validation Passed |
PR Description Check PassedAll required sections are filled in correctly. Details |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up hardening for the
macro.my.id / verifytemplate. Cloudflare suggested constraining the TXT value so a malicious link cannot write an arbitrary value at_macro-verify. This changes the record data from%token%tomacro-verify=%token%and bumps the template version to 2.The public signing key format issue from the onboarding thread was fixed separately by splitting the TXT record into
p=1/p=2chunks; it is unrelated to this template change.Type of change
Verification logic must look for the current token among the values at
_macro-verify; each application adds a new record. The currently onboarded v1 template remains live until this is merged/re-onboarded, so opening this PR does not require an immediate provider-side change.How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserver (HTTP 200)JSON schema validation and linter checks passed on the PR.
Checklist of common problems
syncPubKeyDomainis setwarnPhishingis not set alongsidesyncPubKeyDomainsyncRedirectDomainis settxtConflictMatchingModeis set on every TXT recordmacro-verify=prefixhostlabelhostfield to create a subdomain%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove — not applicable; the single TXT record is template-managedOnline Editor test results
Editor test link(s):
Supersedes #3215 (that branch predated the merged v1 template).