Skip to content

macro.my.id / verify: prefix verification TXT value (v2) - #3216

Open
mbayue wants to merge 1 commit into
Domain-Connect:masterfrom
mbayue:macro-verify-token-prefix-v2
Open

mbayue wants to merge 1 commit into
Domain-Connect:masterfrom
mbayue:macro-verify-token-prefix-v2

Conversation

@mbayue

@mbayue mbayue commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Description

Follow-up hardening for the macro.my.id / verify template. Cloudflare suggested constraining the TXT value so a malicious link cannot write an arbitrary value at _macro-verify. This changes the record data from %token% to macro-verify=%token% and bumps the template version to 2.

The public signing key format issue from the onboarding thread was fixed separately by splitting the TXT record into p=1/p=2 chunks; it is unrelated to this template change.

Type of change

  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

Verification logic must look for the current token among the values at _macro-verify; each application adds a new record. The currently onboarded v1 template remains live until this is merged/re-onboarded, so opening this PR does not require an immediate provider-side change.

How Has This Been Tested?

  • Template functionality checked using Online Editor — apex and host/subdomain apply tests, links below
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver (HTTP 200)

JSON schema validation and linter checks passed on the PR.

Checklist of common problems

  • syncPubKeyDomain is set
  • warnPhishing is not set alongside syncPubKeyDomain
  • syncRedirectDomain is set
  • no TXT record contains SPF content
  • txtConflictMatchingMode is set on every TXT record
  • no variable is used as a bare full record value — this PR fixes that by adding the macro-verify= prefix
  • no bare variable is used as the full host label
  • no variable is used in the host field to create a subdomain
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove — not applicable; the single TXT record is template-managed

Online Editor test results

Editor test link(s):

Supersedes #3215 (that branch predated the merged v1 template).

@github-actions github-actions Bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Nov 19, 2026
@github-actions

Copy link
Copy Markdown

✅ JSON Filename Check Passed

@github-actions

Copy link
Copy Markdown

Linter OK

macro.my.id.verify.json

Level Code Note

@github-actions

Copy link
Copy Markdown

✅ JSON Schema Validation Passed

@github-actions github-actions Bot added automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. and removed Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Nov 19, 2026
@github-actions

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/1 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 2 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant