Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The completed camera/action payload could not reach publication staging because the path allowlist rejected all 16 registered negative-control archive names containing underscores. Admit exactly those names: confirmation groups 00/01, goals 0/1, student controller and the four registered faults. Other underscore-bearing paths remain rejected; the existing relative-path, roster, schema, byte/hash, checksum and credential-boundary checks are unchanged.
This is a maintainer publisher fix stacked on
feat/piper-camera-action-v01. The publisher runs from this PR's commit against the existing payload whose delivery source remainsd89b24c82b7534a439bbaa3cac3ef5c9d3b80088; the registered runtime remainsc9a7c55531533f60e24651a99d509f721e195051. No prepared archives, source/wheel, cards, model, frozen runtime or qualification result change, and no expensive preparation rerun is needed. Full byte/secret/checksum staging is still required before upload.Validation: the regression reproduces 16 rejected paths and the staging refusal before the fix. All 21 publisher tests and 45 preparation/card/hardware/renderer tests pass afterward, including malformed paths, checksum tampering, changed payload bytes and refusal before credential access. Independent review reran the publisher suite and checked 1,500 bounded negative-path combinations: exactly the 16 registered paths are newly admitted. A read-only path check against prepared manifest SHA-256
8d1c4c276354ca0ad3dd2b54737860950e89cf5082f0fffff59a60e79ba0eafcadmits all 473 listed files and exactly those 16 additions. This check read no archive bytes and performed no upload, credential access, simulation or fitting.