Repository navigation
Fix embedded section controls and table word wrapping - #534
Merged
Merged
Conversation
PrzemyslawKlys
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section Show/Hide controls now work when a report is embedded under a nonce-based script policy. Delegated event listeners replace inline
onclickattributes while preserving the host's policy and the existingshow()andhide()functions.The existing
WordBreaktable option now emits valid CSS and overrides the default first-column nowrap style. Long values wrap inside the report frame instead of being clipped.Online and offline reports embed the section script from the module, including the filename casing needed on Linux. Ubuntu CI uses the runner-provided PowerShell, and the native release configuration selects the current Evotec signing certificate.
Validation: Online/offline generation passed on PowerShell 7, Windows PowerShell 5.1, and a case-sensitive Linux filesystem. Browser checks reproduced the original failure, verified mouse and keyboard toggling under the same nonce-restricted iframe using UltimateHtmlViewer's HTML transform, and exercised a standalone Online report. Unsigned native package imports and generation passed on both Windows runtimes with approved donors unavailable. Independent local review and targeted confirmation completed.
The wrapping regression is covered by generated CSS checks and an actual 500-pixel viewer fixture with a long device name.
This shared fix is consumed by CleanupMonster#74, which requires PSWriteHTML 1.42.0. The embedded-report checks use the existing HTML transformation from UltimateHtmlViewer.