Repository navigation
Fix first-tab hash navigation in nested panels - #535
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash changes to the first tab leave the current tab visible because SmartTab treats index zero as a missing index. Compare the lookup result explicitly with
falsein the hashchange handler and the initial selection fallback, preserving index zero and the existing back-button and enabled-tab checks.The standalone generated-report browser regression covers Back/Forward, direct hash edits, an in-document link to the first tab of a nested panel, unknown hashes, and initial first-tab links with a configured second tab. It uses the existing PSParseHTML browser session and installed Edge in headless mode. Serve the supplied report directory on loopback before invoking
Tests/Browser/Invoke-TabHashNavigationTest.ps1.Validation: the original vendor handler fails the first-tab hash test, and the original initial-load fallback fails a fresh first-tab link over a configured second tab; the patched handler passes all nine cases in PowerShell 7 and Windows PowerShell 5.1. All 76 existing Pester tests pass in each host. Headless captures at 390, 1024 and 1440 under light and dark system preferences are posted for running-report review. The report keeps its existing palette under both preferences. No dependency, layout or package release change is included.