Skip to content

add org. units imported to history summary - #415

Merged
adrianq merged 5 commits into
developmentfrom
feature/add-orgunit-history-869cc53c7
Aug 26, 2026
Merged

adrianq merged 5 commits into
developmentfrom
feature/add-orgunit-history-869cc53c7

Conversation

@eperedo

@eperedo eperedo commented Aug 16, 2026 •

Copy link
Copy Markdown

📌 References

📝 Implementation

  • Include org. units imported in import template process
  • Show org. units in history
  • Show a preview message on the import data page if user does not have the required authorities (ALL or F_DOCUMENT_PRIVATE_ADD) to avoid confussion on why the user can see the entry on the history page, but not able to download the file. (to confirm with @adrianq if this is the best solution)

🔥 Notes for the reviewer

📹 Screenshots/Screen capture

Org. units in history details

Bulk-Load-DHIS2_orig_unit_history.mp4

Warning alert in case user does not have permissions to upload documents

image

📑 Others

@eperedo
eperedo requested a review from adrianq August 16, 2026 20:25
@bundlemon

bundlemon Bot commented Aug 16, 2026 •

Copy link
Copy Markdown

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
✅ Build Folder
./**/*
1.73MB (+1.95KB +0.11%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@adrianq
adrianq requested a review from anagperal August 20, 2026 08:56

@anagperal anagperal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eperedo ! The feature works. I've added two comments that are non-bloking but it's worth to check it.

import { RouteComponentProps } from "../Router";
import { TemplateDataPackage, templateToDataPackage } from "../../../domain/entities/Template";
import { WarningAlert } from "../../components/warning-alert/WarningAlert";
import { documentUploadAuthorities } from "../../../data/d2-authorities";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non-blocking] It imports documentUploadAuthorities directly from src/data/d2-authorities.ts and uses it at runtime to build the warning message. It would be cleaner to move this into Settings instead, not because it fixes the layering (Settings already reaches into data/ itself), but at least everything would be accessed through one single point instead of two separate ones importing from data/ independently

Comment thread i18n/es.po Outdated
msgstr ""

msgid "and {{total}} more"
msgstr "y {{count}} más"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non-blocking] Review translations. Here for example uses count instead of total (See src/webapp/components/history/HistoryImportSummary.tsx)

@eperedo
eperedo requested a review from anagperal August 24, 2026 12:56

@anagperal anagperal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eperedo !

@adrianq
adrianq merged commit 9f2e0b7 into development Aug 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants