Repository navigation
add org. units imported to history summary - #415
Merged
Merged
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
…ture/add-orgunit-history-869cc53c7
anagperal
requested changes
Aug 20, 2026
| import { RouteComponentProps } from "../Router"; | ||
| import { TemplateDataPackage, templateToDataPackage } from "../../../domain/entities/Template"; | ||
| import { WarningAlert } from "../../components/warning-alert/WarningAlert"; | ||
| import { documentUploadAuthorities } from "../../../data/d2-authorities"; |
There was a problem hiding this comment.
[non-blocking] It imports documentUploadAuthorities directly from src/data/d2-authorities.ts and uses it at runtime to build the warning message. It would be cleaner to move this into Settings instead, not because it fixes the layering (Settings already reaches into data/ itself), but at least everything would be accessed through one single point instead of two separate ones importing from data/ independently
| msgstr "" | ||
|
|
||
| msgid "and {{total}} more" | ||
| msgstr "y {{count}} más" |
There was a problem hiding this comment.
[non-blocking] Review translations. Here for example uses count instead of total (See src/webapp/components/history/HistoryImportSummary.tsx)
anagperal
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
🔥 Notes for the reviewer
📹 Screenshots/Screen capture
Org. units in history details
Bulk-Load-DHIS2_orig_unit_history.mp4
Warning alert in case user does not have permissions to upload documents
📑 Others