Repository navigation
fix(lyrics): treat KuGou's instrumental notice as no lyrics - #1573
Merged
A-EDev merged 3 commits intoNov 16, 2026
Merged
Conversation
KuGou answers instrumental tracks with a one-line lyric, "纯音乐,请欣赏"
("pure music, please enjoy"), which showed as the song's lyrics. Treat an
answer made only of that notice as no lyrics, so the lookup moves on to the
next provider or shows "Lyrics not available". Lyrics that merely contain
the phrase are kept.
Notices already in the lyrics cache stay until it is cleared in the storage
settings; evicting them was left out to keep the fix to the provider.
Assisted-by: Claude Code (Claude Opus 5.5)
7 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KuGou answers instrumental tracks with a one-line lyric, "纯音乐,请欣赏" ("pure music, please enjoy"), so songs such as Ólafur Arnalds' "Happiness Does Not Wait" showed it as their lyrics instead of "Lyrics not available".
KuGouLyricsProvider.kt:isInstrumentalNoticematches an answer made only of that notice (full-width or ASCII comma), and the provider returns no lyrics for it, so the lookup moves on to the next provider. Lyrics that merely contain the phrase are kept.KuGouLyricsProviderTest(2 cases).Flow Desktop has the same fix in Flow-Tube/Flow-Desktop#342. Other apps have hit it too (kushagrasinghx/BitChord#716).
Related issue
None filed.
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(4658 tests; the 22 failures inProfileRegistryTest,ProfileFilesTestandDeviceKeysCopyTestfail the same onmainon this Windows machine)ktlintCheck)Test device and Android version:
Pixel 10 Pro · Android 17 (SDK 37)
Played "Happiness Does Not Wait". Before the fix the lyrics screen showed "纯音乐,请欣赏"; on this branch it shows "Lyrics not available" and nothing is saved to the lyrics cache.
Screenshots or recordings
Before on the left, this branch on the right.
Risk and compatibility
Limited to KuGou's answers; nothing stored changes. Notices already saved in the lyrics cache stay until it is cleared (the "Other" cache in storage settings); evicting them was left out to keep the fix to the provider.
AI disclosure: This PR was largely written by Claude (Opus 5.5) but was fully reviewed and tested by myself before raising this.