Skip to content

fix(lyrics): treat KuGou's instrumental notice as no lyrics - #1573

Merged
A-EDev merged 3 commits into
Flow-Tube:mainfrom
AmyJeanes:pr/kugou-instrumental-placeholder
Nov 16, 2026
Merged

A-EDev merged 3 commits into
Flow-Tube:mainfrom
AmyJeanes:pr/kugou-instrumental-placeholder

Conversation

@AmyJeanes

Copy link
Copy Markdown
Contributor

Summary

KuGou answers instrumental tracks with a one-line lyric, "纯音乐,请欣赏" ("pure music, please enjoy"), so songs such as Ólafur Arnalds' "Happiness Does Not Wait" showed it as their lyrics instead of "Lyrics not available".

  • KuGouLyricsProvider.kt: isInstrumentalNotice matches an answer made only of that notice (full-width or ASCII comma), and the provider returns no lyrics for it, so the lookup moves on to the next provider. Lyrics that merely contain the phrase are kept.
  • Tests: KuGouLyricsProviderTest (2 cases).
  • Nightly changelog note added - please let me know if this wasn't the right format!

Flow Desktop has the same fix in Flow-Tube/Flow-Desktop#342. Other apps have hit it too (kushagrasinghx/BitChord#716).

Related issue

None filed.

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (4658 tests; the 22 failures in ProfileRegistryTest, ProfileFilesTest and DeviceKeysCopyTest fail the same on main on this Windows machine)
  • I ran any additional flavor-specific build or test tasks affected by this change. (ktlintCheck)
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version:

Pixel 10 Pro · Android 17 (SDK 37)

Played "Happiness Does Not Wait". Before the fix the lyrics screen showed "纯音乐,请欣赏"; on this branch it shows "Lyrics not available" and nothing is saved to the lyrics cache.

Screenshots or recordings

Before on the left, this branch on the right.

kugou-android

Risk and compatibility

Limited to KuGou's answers; nothing stored changes. Notices already saved in the lyrics cache stay until it is cleared (the "Other" cache in storage settings); evicting them was left out to keep the fix to the provider.

AI disclosure: This PR was largely written by Claude (Opus 5.5) but was fully reviewed and tested by myself before raising this.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources. (no new text)
  • Dependency and lockfile changes are intentional and limited to this PR. (none)
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented. (none)

KuGou answers instrumental tracks with a one-line lyric, "纯音乐,请欣赏"
("pure music, please enjoy"), which showed as the song's lyrics. Treat an
answer made only of that notice as no lyrics, so the lookup moves on to the
next provider or shows "Lyrics not available". Lyrics that merely contain
the phrase are kept.

Notices already in the lyrics cache stay until it is cleared in the storage
settings; evicting them was left out to keep the fix to the provider.

Assisted-by: Claude Code (Claude Opus 5.5)
@AmyJeanes
AmyJeanes requested a review from A-EDev as a code owner October 30, 2026 00:20
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 30, 2026
@A-EDev
A-EDev merged commit c404f61 into Flow-Tube:main Nov 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants