Repository navigation
fix(lyrics): treat KuGou's instrumental notice as no lyrics - #342
Merged
A-EDev merged 5 commits intoNov 4, 2026
Merged
Conversation
KuGou answers instrumental tracks with a one-line lyric, "纯音乐,请欣赏"
("pure music, please enjoy"), which showed as a synced lyric line. Treat an
answer made only of that notice as no lyrics, so the lookup moves on to the
next provider or shows "Lyrics not available". Lyrics that merely contain
the phrase are kept.
Notices already in the lyrics cache stay until the cache is cleared in
Settings; evicting them was left out to keep the fix to the provider.
Assisted-by: Claude Code (Claude Opus 5.5)
10 of 14 tasks
Co-authored-by: Amy Jeanes <amyjeanes23@gmail.com>
Co-authored-by: Amy Jeanes <amyjeanes23@gmail.com>
Co-authored-by: Amy Jeanes <amyjeanes23@gmail.com>
9 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KuGou answers instrumental tracks with a one-line lyric, "纯音乐,请欣赏" ("pure music, please enjoy"), so songs such as Ólafur Arnalds' "Happiness Does Not Wait" showed it as a synced lyric line instead of "Lyrics not available".
lyricsUtils.ts:isInstrumentalNoticematches an answer made only of that notice (full-width or ASCII comma). Lyrics that merely contain the phrase are kept.kugou.ts:getLyricsstops at the notice and returns no lyrics, so the lookup moves on to the next provider. KuGou's other matches for the title can be a vocal version of the song, so they are not tried.lyricsHelper.ts: a notice already in the disk cache is evicted when it is read, so it stops coming back as the fallback.providers.test.ts, using the file KuGou actually serves (every instrumental points at the same lyric id, 19525574), 3 in a newkugou.test.tsfor the search, and 2 inlyricsHelper.test.tsfor the cache.Android parity: Flow-Android has the same bug; the matching fix is Flow-Tube/Flow#1573, with the same check in
KuGouLyricsProvider. Android downloads one candidate, so it stops at the notice the same way. Other apps have hit it too (kushagrasinghx/BitChord#716).Related issue
None filed.
Change type
Validation
Windows 11 x64.
pnpm test(212 files, 1243 tests passed, with main merged at 01e0869, on macOS)pnpm build(also on macOS with main merged)cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check(no Rust changes)cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features(no Rust changes)cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features(no Rust changes)Smoke test: played "Happiness Does Not Wait" on a build of
mainand on this branch.mainshows "纯音乐,请欣赏" in the lyrics pane; this branch shows "Lyrics not available".Live KuGou lookups on the final branch, provider only: 7 instrumental songs, including "Nuvole Bianche" at 357 s, each return no lyrics in 3 requests.
Screenshots or recordings
mainon top, this branch below:Risk and compatibility
Frontend only, limited to KuGou's answers and the lyrics cache entries that hold its notice. No migrations, database or permissions changes. Network use is unchanged from
main: 3 requests for an instrumental. No overlap with other open PRs.AI disclosure: This PR was largely written by Claude (Opus 5.5) but was fully reviewed and tested by myself before raising this.