Skip to content

docs: make the CashPilot-Desktop follow-up part of every PR here, so a fix never lands on the web app alone #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeiserX merged 1 commit into from
Oct 12, 2026
Merged

docs: make the CashPilot-Desktop follow-up part of every PR here, so a fix never lands on the web app alone #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@
- [ ] Guide page added in `docs/guides/` (if new service)
- [ ] README service table updated (if new service)
- [ ] No credentials or secrets committed
- [ ] CashPilot-Desktop follow-up linked, or the Summary says why Desktop needs nothing (catalog, deploy form, deploy validation and guide facts all have a counterpart there)
12 changes: 12 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,18 @@ Base URL: `https://api.bringyour.com`
- Keep Docker image under 100 MB
- All Python code must pass `ruff` linting

## CashPilot-Desktop mirrors this repo

[CashPilot-Desktop](https://github.com/GeiserX/CashPilot-Desktop) is the same product as a Go and TypeScript app. It vendors `services/` byte for byte (`make catalog-sync SRC=../CashPilot` over there, with the Desktop-only digest pins in `catalog-overlay/image-pins.yml`), and it re-implements the deploy form, the deploy validation and the catalog's facts in its own code. A fix that lands here alone is a fix half the users never get.

Every PR here that touches one of these gets a Desktop follow-up in the same session, and the follow-up's link goes in the report next to this repo's:

- `services/`: sync the catalog in Desktop. A new live service with a floating image needs a digest pin there first, or the sync refuses.
- The deploy route or the deploy form (`api_deploy` in `app/main.py`; `envInputFields` and `_deployToWorkers` in `app/static/js/app.js`): port the behaviour to `internal/services` and `frontend/src/render` in Desktop, with its test.
- `docs/guides/`: Desktop has no guides, but a fact that changed there (a payout rate, a caution, a recovery step) usually also sits in the catalog text, which the sync carries.

When Desktop needs nothing, the PR body says so and why. The PR template asks for it. Desktop's weekly drift check (`catalog-drift.yml`, the standing "Catalog drift" issue) is the backstop, not the plan: it sees the catalog and never a behaviour change.

## What NOT to Build Yet

- Auto-discovery (mDNS, Tailscale API)
Expand Down
Loading