Repository navigation
Conversation
Move Linux GitHub Actions jobs to [self-hosted, godesk], add concurrency, and install language toolchains with setup-* actions so the jobs do not assume a GitHub-hosted image. Do not merge until the GoDesk runners are confirmed online.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Richard is registering GoDesk self-hosted runners (labels
self-hosted,linux,x64,godesk) on komboe-build-g4 and GoDesk5 so Linux CI can leave GitHub-hosted minutes.Do not merge until those runners are confirmed online. Merging earlier would leave every Linux job queued.
Changes
ubuntu-*(and Traffic jobs that usedblacksmith-*-ubuntu-*) now useruns-on: [self-hosted, godesk].ubuntu-24.04-arm, the existingdad-chromium-buildrunner, and Valkey EC2 benchmark runners are unchanged.concurrencywithcancel-in-progressis added where it was missing. Release/tag workflows usecancel-in-progress: ${{ !startsWith(github.ref, 'refs/tags/') }}.setup-node,setup-python,setup-go,dtolnay/rust-toolchain, orsetup-androidso the jobs do not assume a GitHub-hosted image.Jobs moved to
[self-hosted, godesk]auto-author-assign.yml:assign-authorbenchmark-on-demand.yml:resolve-prbenchmark-release.yml:combine-resultsci.yml:validate-commands-defci.yml:test-ubuntu-latestci.yml:test-ubuntu-latest-compatibilityci.yml:test-ubuntu-latest-cmake-tlsci.yml:test-sanitizer-addressci.yml:test-rdmaci.yml:test-tls-onlyci.yml:build-debian-oldci.yml:build-32bitci.yml:build-libc-mallocci.yml:build-almalinux8-jemallocci.yml:format-yamlclang-format.yml:clang-format-checkcmo-ci.yml:servercmo-ci.yml:imagecmo-ci.yml:autocrlfcmo-ci.yml:packagecmo-ci.yml:k8scmo-ci.yml:sitecodecov.yml:code-coveragecodeql-analysis.yml:analyzecoverity.yml:coveritydaily.yml:test-s390xdaily.yml:test-ubuntu-reclaim-cachedaily.yml:consolidate-test-failuresdaily.yml:notify-about-job-resultsexternal.yml:test-external-standaloneexternal.yml:test-external-clusterexternal.yml:test-external-nodebugmajor-decision-auto-approve.yml:approveprovenance-check.yml:checkprovenance-refresh.yml:refreshreply-schemas-linter.yml:reply-schemas-linterreuse.yml:reusescorecard.yml:analysisspell-check.yml:buildtrigger-build-release.yml:triggerupstream-sync.yml:syncweekly.yml:determine-release-branchesJobs left on GitHub-hosted or existing specialized runners
benchmark-on-demand.yml:benchmarkbenchmark-on-label.yml:benchmarkbenchmark-release.yml:benchmarkci.yml:build-macos-latestdaily.yml:test-ubuntu-armdaily.yml:test-macos-latestdaily.yml:test-macos-latest-sentineldaily.yml:test-macos-latest-clusterdaily.yml:build-old-macos-versionsDocker-dependent jobs (need Docker on the runner host)
ci.yml:build-debian-oldci.yml:build-almalinux8-jemalloccmo-ci.yml:imagecmo-ci.yml:autocrlfcmo-ci.yml:packagecmo-ci.yml:k8sdaily.yml:test-ubuntu-jemalloc-fortifydaily.yml:test-rpm-distros-jemallocdaily.yml:test-rpm-distros-tls-moduledaily.yml:test-rpm-distros-tls-module-no-tlsdaily.yml:test-alpine-jemallocdaily.yml:test-alpine-libc-mallocdaily.yml:test-alpine-32bitNotes
ubuntu-24.04-armstays GitHub-hosted because the GoDesk runners are x64. Existingec2-al-2023-pr-benchmarking-*self-hosted jobs are left alone (they are Valkey-specific and already gated). C compile jobs still needgcc/make/tclon the runner host; those are system packages, not setup-* actions.