Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .config/typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Hashi = "Hashi" # HashiCorp, which the checker splits before Corp
dbe = "dbe"
cmo = "cmo"
CMO = "CMO"
Pn = "Pn"
pn = "pn"

[default]
extend-ignore-re = [
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-author-assign.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ concurrency:

jobs:
assign-author:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- uses: toshimaru/auto-author-assign@4d585cc37690897bd9015942ed6e766aa7cdb97f # v3.0.1
2 changes: 1 addition & 1 deletion .github/workflows/benchmark-on-demand.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ concurrency:
jobs:
resolve-pr:
if: github.repository == 'valkey-io/valkey'
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
# Read-only access to the PR is enough to call pulls.get.
permissions:
contents: read
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/benchmark-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ permissions:

concurrency:
group: benchmark-release-${{ inputs.version1 }}-${{ inputs.version2 }}
cancel-in-progress: true

cancel-in-progress: ${{ !startsWith(github.ref, 'refs/tags/') }}
jobs:
benchmark:
if: github.repository == 'valkey-io/valkey'
Expand Down Expand Up @@ -238,7 +237,7 @@ jobs:

combine-results:
needs: benchmark
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Download all artifacts
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ permissions:

jobs:
validate-commands-def:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Checkout Valkey
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand All @@ -32,7 +32,7 @@ jobs:
git ls-files --error-unmatch src/commands.def > /dev/null

test-ubuntu-latest:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
make test-unit

test-ubuntu-latest-compatibility:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
--other-server-path tests/tmp/valkey-${{ matrix.server.version }}-noble-x86_64/bin/valkey-server

test-ubuntu-latest-cmake-tls:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: cmake and make
Expand All @@ -124,7 +124,7 @@ jobs:
run: make -C build-release test-unit

test-sanitizer-address:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand All @@ -151,7 +151,7 @@ jobs:
make test-unit

test-rdma:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down Expand Up @@ -185,7 +185,7 @@ jobs:
run: sudo dmesg -c

test-tls-only:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: generate-test-certificates
Expand All @@ -204,7 +204,7 @@ jobs:
run: ./runtest --verbose --single unit/tls --dump-logs --tls

build-debian-old:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
container: debian:bookworm
steps:
- name: Install libbacktrace
Expand Down Expand Up @@ -254,7 +254,7 @@ jobs:
make test-unit

build-32bit:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down Expand Up @@ -306,7 +306,7 @@ jobs:
GTEST_LIBS="/usr/lib32/libgtest.a /usr/lib32/libgmock.a"

build-libc-malloc:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand All @@ -321,7 +321,7 @@ jobs:
run: make -j4 SERVER_CFLAGS='-Werror' MALLOC=libc USE_LIBBACKTRACE=yes

build-almalinux8-jemalloc:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
container: almalinux:8
steps:
- name: Install libbacktrace
Expand All @@ -340,7 +340,7 @@ jobs:
run: make -j4 SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes

format-yaml:
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down
21 changes: 14 additions & 7 deletions .github/workflows/clang-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,27 @@ concurrency:

jobs:
clang-format-check:
runs-on: ubuntu-latest

runs-on: [self-hosted, godesk]
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Set up Clang
run: |
set -euo pipefail
sudo apt-get update -y
sudo apt-get install software-properties-common -y
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor | sudo tee /usr/share/keyrings/llvm-toolchain.gpg > /dev/null
echo "deb [signed-by=/usr/share/keyrings/llvm-toolchain.gpg] http://apt.llvm.org/$(lsb_release -cs)/ llvm-toolchain-$(lsb_release -cs)-18 main" | sudo tee /etc/apt/sources.list.d/llvm.list
sudo apt-get update -y
sudo apt-get install clang-format-18 -y
# Debian 13 has no software-properties-common. Prefer the distro
# clang-format; fall back to apt.llvm.org for clang-format-18.
if apt-cache show clang-format-18 >/dev/null 2>&1; then
sudo apt-get install -y clang-format-18
else
sudo apt-get install -y wget gnupg lsb-release
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor | sudo tee /usr/share/keyrings/llvm-toolchain.gpg > /dev/null
echo "deb [signed-by=/usr/share/keyrings/llvm-toolchain.gpg] http://apt.llvm.org/$(lsb_release -cs)/ llvm-toolchain-$(lsb_release -cs)-18 main" | sudo tee /etc/apt/sources.list.d/llvm.list
sudo apt-get update -y
sudo apt-get install -y clang-format-18
fi
clang-format-18 --version
- name: Run clang-format
id: clang-format
run: |
Expand Down
49 changes: 42 additions & 7 deletions .github/workflows/cmo-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,16 @@ permissions:
jobs:
server:
name: Build and test subset
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
timeout-minutes: 40
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- uses: actions/setup-go@v5
with:
go-version: "1.25.x"

- name: Install build and test packages
run: |
sudo apt-get update
Expand Down Expand Up @@ -50,7 +54,7 @@ jobs:

image:
name: Docker image and smoke
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
timeout-minutes: 45
steps:
- name: Checkout
Expand Down Expand Up @@ -165,7 +169,7 @@ jobs:

autocrlf:
name: Image build with autocrlf
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
timeout-minutes: 30
steps:
- name: Checkout
Expand Down Expand Up @@ -207,7 +211,7 @@ jobs:

package:
name: Debian package smoke
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
timeout-minutes: 40
steps:
- name: Checkout
Expand Down Expand Up @@ -244,7 +248,7 @@ jobs:

k8s:
name: Helm lint and kind smoke
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
timeout-minutes: 40
steps:
- name: Checkout
Expand Down Expand Up @@ -363,12 +367,43 @@ jobs:

site:
name: Site, integration, and browser
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Set up Python 3.12
env:
PYTHON_VERSION: "3.12"
run: |
set -euo pipefail
export PATH="/usr/local/bin:$HOME/.local/bin:$PATH"
echo "/usr/local/bin" >> "$GITHUB_PATH"
echo "$HOME/.local/bin" >> "$GITHUB_PATH"
if ! command -v uv >/dev/null 2>&1; then
curl -LsSf https://astral.sh/uv/install.sh | sh
export PATH="$HOME/.local/bin:$PATH"
fi
PY=""
if [ -x "/usr/local/bin/python${PYTHON_VERSION}" ]; then
PY="/usr/local/bin/python${PYTHON_VERSION}"
elif command -v "python${PYTHON_VERSION}" >/dev/null 2>&1; then
PY="$(command -v "python${PYTHON_VERSION}")"
else
uv python install "$PYTHON_VERSION"
PY="$(uv python find "$PYTHON_VERSION")"
fi
VENV="$RUNNER_TEMP/python"
uv venv --seed --python "$PY" "$VENV"
echo "$VENV/bin" >> "$GITHUB_PATH"
"$VENV/bin/python" --version
"$VENV/bin/python" -m pip install --upgrade pip

- uses: actions/setup-node@v4
with:
node-version: "22"

- name: Unit tests for the site and the management API
run: |
python3 tools/mgmt/test_cmo_mgmt.py
Expand All @@ -381,7 +416,7 @@ jobs:
working-directory: site/e2e
run: |
npm ci
npx playwright install --with-deps chromium
npx playwright install chromium

- name: Browser tests
working-directory: site/e2e
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ concurrency:

jobs:
code-coverage:
runs-on: ubuntu-22.04

runs-on: [self-hosted, godesk]
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ permissions:
jobs:
analyze:
name: Analyze
# cpp autobuild OOMed the 8 GiB runner once and then failed cmake
# autobuild under the 5G heavy slice. Keep this job on GitHub-hosted.
runs-on: ubuntu-latest
if: github.event_name != 'schedule' || github.repository == 'valkey-io/valkey'
permissions:
Expand All @@ -44,8 +46,11 @@ jobs:
with:
languages: ${{ matrix.language }}

- name: Autobuild
uses: github/codeql-action/autobuild@c793b717bc78562f491db7b0e93a3a178b099162 # v4.32.5
# cmake autobuild fails with "server.h: No such file or directory"
# (src/tier/tier.h) on both the self-hosted runner and ubuntu-latest,
# and is already red on unstable. The project is built with make.
- name: Build
run: make -j"$(nproc)"

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@c793b717bc78562f491db7b0e93a3a178b099162 # v4.32.5
2 changes: 1 addition & 1 deletion .github/workflows/coverity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ permissions:
jobs:
coverity:
if: github.repository == 'valkey-io/valkey'
runs-on: ubuntu-latest
runs-on: [self-hosted, godesk]
steps:
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down
Loading
Loading