fix: support optional C in Gemm - #870
Draft
voltjia wants to merge 2 commits into
Draft
Conversation
voltjia
force-pushed
the
fix/align-gemm-with-onnx-semantics
branch
4 times, most recently
from
August 4, 2026 08:38
6fb4a68 to
e634686
Compare
19 tasks
voltjia
force-pushed
the
fix/align-gemm-with-onnx-semantics
branch
from
August 4, 2026 09:38
e634686 to
0afa1e4
Compare
BREAKING CHANGE: Gemm now accepts optional C before attributes and writes Y; non-null C is not implemented yet.
voltjia
force-pushed
the
fix/align-gemm-signature
branch
from
August 5, 2026 00:12
15dd340 to
b33fccd
Compare
voltjia
force-pushed
the
fix/align-gemm-with-onnx-semantics
branch
from
August 5, 2026 00:12
0afa1e4 to
256fcad
Compare
voltjia
force-pushed
the
fix/align-gemm-signature
branch
6 times, most recently
from
August 5, 2026 07:12
cec9c4a to
65923dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
#878 changes the public Gemm signature immediately and temporarily rejects non-null C. This follow-up completes the aligned contract without mixing the larger backend implementation into the API-only review.
Depends on #878.
Type of Change
Platforms Affected
Smoke Test Result
Exact-head build, Ruff, and both clang-format checks passed for 256fcad. Platform unit workflows are not currently listed for this stacked-head update.
The implementation files remain aligned with the previously validated #870 implementation. The stack rewrite changes the parent interface commit and keeps all newly added test cases in this implementation PR.
Test Results on Supported Platforms
Focused test notes
Benchmark / Performance Impact
No benchmark was run. Independent or broadcast C requires a post-GEMM elementwise accumulation on classic BLAS and CNNL paths. Omitted C remains a single GEMM with beta zero.
Notes for Reviewers