fix!: align Gemm public signature - #878
Merged
Merged
Conversation
voltjia
force-pushed
the
fix/align-gemm-signature
branch
5 times, most recently
from
August 5, 2026 03:15
a3e4ea0 to
362fce6
Compare
19 tasks
voltjia
force-pushed
the
fix/align-gemm-signature
branch
from
August 5, 2026 05:53
362fce6 to
cec9c4a
Compare
BREAKING CHANGE: Gemm now accepts optional C before attributes and writes Y; non-null C is not implemented yet.
voltjia
force-pushed
the
fix/align-gemm-signature
branch
from
August 5, 2026 07:12
cec9c4a to
65923dc
Compare
voltjia
marked this pull request as ready for review
August 5, 2026 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemm(a, b, optional C, alpha, beta, trans_a, trans_b, Y).Gemm(a, b, Y)overload; omitted C always uses an effective beta of zero.Motivation
The legacy full overload used the writable result tensor as both C and Y, so its public signature did not match the open-source framework contract. This precursor changes the API now while keeping backend arithmetic unchanged; #870 will add independent and broadcast C support separately.
No linked issue. The mismatch was found during the operator API alignment audit.
Type of Change
Platforms Affected
Smoke Test Result
Exact-head GitHub CI for
362fce68is running after a comment-only update. Its code-identical predecessora3e4ea01had:src/base/flash_attn_varlen_func.h; the first error is at line 56, followed by the same ShapeView/StridesView versus SmallVector ternary mismatch at lines 58, 66, and 68. The logs contain no Gemm error.The NVIDIA difference from the last green master run is dependency drift: CI clones InfiniRT master without a pinned SHA. The master run cloned InfiniRT before
a38977e0; #878 cloned that commit after it changed TensorView metadata accessors and exposed the existing FlashAttention mismatch. This compatibility fix is unrelated to Gemm and is intentionally not included here.Focused validation for the same code at
a3e4ea01:Test Results on Supported Platforms
Full pytest output (optional)
Benchmark / Performance Impact
N/A. Backend arithmetic is unchanged. Calls with omitted C force the effective beta to zero and do not read Y.
Notes for Reviewers
operator()signatures directly; it does not introduce a virtualComputelayer.BREAKING CHANGE: Gemm now accepts optional C before its attributes and writes Y; non-null C is not implemented until #870.