Repository navigation
Run the dx-built example and the Windows tests in CI - #12
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## d1-dioxus #12 +/- ##
==========================================
Coverage 91.83% 91.83%
==========================================
Files 33 33
Lines 2841 2841
Branches 37 37
==========================================
Hits 2609 2609
Misses 205 205
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
c1-ci-gaps
branch
from
October 9, 2026 01:46
9579d6d to
40ee94d
Compare
LucaCappelletti94
force-pushed
the
c1-ci-gaps
branch
from
October 9, 2026 03:32
dc578f2 to
5822c3b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the three CI jobs the device checks showed were missing. The tests now run on a Windows runner, which has no Windows App SDK runtime, so
installis checked as an unpackaged app without the bootstrapper sees it. The dx-builtexamples/dioxusruns in headless Chrome in static-worker mode, with its manifest, its bundled worker and real pushes to an open and a closed page, and the same example runs as an APK on an API 35 emulator through real FCM, open and killed.The example also registers for UnifiedPush and Linux when it is built with a VAPID key, the build the A35 and Plasma proofs used. It sits on #11, which adds the
dioxusfeature, and checks the Windows backend from #9.