Repository navigation
Deliver taps that reach a running Activity through onNewIntent - #13
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LucaCappelletti94
force-pushed
the
t1-new-intent-taps
branch
from
October 9, 2026 01:45
9602c24 to
579e647
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## c1-ci-gaps #13 +/- ##
==============================================
+ Coverage 91.83% 91.91% +0.07%
==============================================
Files 33 33
Lines 2841 2844 +3
Branches 37 38 +1
==============================================
+ Hits 2609 2614 +5
+ Misses 205 203 -2
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
t1-new-intent-taps
branch
from
October 9, 2026 02:43
579e647 to
25cf897
Compare
LucaCappelletti94
force-pushed
the
t1-new-intent-taps
branch
from
October 9, 2026 03:32
25cf897 to
b1a32d9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



A notification tap into an app whose Activity is
singleToporsingleTaskand already running reaches that Activity'sonNewIntentand creates no Activity, so the crate, which read taps only inonActivityCreated, lost every such tap. A new instrumented variant showed it on an A35. An androidx Activity now reports the new intent through itsOnNewIntentProviderlistener, and a plain Activity whoseonNewIntentcallssetIntentis read on resume, with the delivered ids keeping each tap to one delivery. The README names thesetIntentcall for plain Activities.Both paths have an instrumented test that failed before the change and passes after, in a new
single-topvariant that the emulator job from #12 runs. It builds on the tap handling from #2.