Skip to content

Deliver taps that reach a running Activity through onNewIntent - #13

Merged
LucaCappelletti94 merged 3 commits into
c1-ci-gapsfrom
t1-new-intent-taps
Oct 10, 2026
Merged

LucaCappelletti94 merged 3 commits into
c1-ci-gapsfrom
t1-new-intent-taps

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Owner

A notification tap into an app whose Activity is singleTop or singleTask and already running reaches that Activity's onNewIntent and creates no Activity, so the crate, which read taps only in onActivityCreated, lost every such tap. A new instrumented variant showed it on an A35. An androidx Activity now reports the new intent through its OnNewIntentProvider listener, and a plain Activity whose onNewIntent calls setIntent is read on resume, with the delivered ids keeping each tap to one delivery. The README names the setIntent call for plain Activities.

Both paths have an instrumented test that failed before the change and passes after, in a new single-top variant that the emulator job from #12 runs. It builds on the tap handling from #2.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f9aab104-ee2e-4625-a0ab-6c2cecb87ab3

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.91%. Comparing base (5822c3b) to head (b1a32d9).

Files with missing lines Patch % Lines
android/src/main/kotlin/rs/pushups/ProcessState.kt 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           c1-ci-gaps      #13      +/-   ##
==============================================
+ Coverage       91.83%   91.91%   +0.07%     
==============================================
  Files              33       33              
  Lines            2841     2844       +3     
  Branches           37       38       +1     
==============================================
+ Hits             2609     2614       +5     
+ Misses            205      203       -2     
  Partials           27       27              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@LucaCappelletti94
LucaCappelletti94 merged commit 8c15151 into main Oct 10, 2026
25 of 45 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the t1-new-intent-taps branch October 10, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant