Repository navigation
Wait for the app to leave the foreground before the single-top push - #18
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 33 33
Lines 2910 2910
Branches 39 39
=======================================
Hits 2682 2682
Misses 201 201
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



SingleTopTapTest, added in #13, failed in 7 of 47 runs of the API 35 emulator job and 1 of 47 on API 29, and twice in a row on #17. The test sends a notification push right after pressing home, andfirebase-messagingshows a notification only when the process importance is belowIMPORTANCE_FOREGROUND(DisplayNotification.isAppForegroundin 25.1.3). A push that lands before the Activity stops goes toonMessageReceivedinstead, so the shade never gets the notification the test waits 90 seconds to tap. Run 15 times on a Galaxy A35 with Android 15, the test failed once, and in that run the probe received the push 34 ms beforeTapActivitystopped.The test now waits, within
UI_MS, for the process to leave the foreground before it sends, which is the same check FCM makes. With that change the same loop passed 30 times out of 30, and no push reached the handler.No CI log showed any of this, because
run.shkept the last 300 device lines containingpushups, which the UI polls for the notification title and every system line naming the package filled. The dump now selects the crate's tag, the FCM tags and the activity and test runner tags, and on the A35 failure it keeps the foreground delivery and the error in view.