Skip to content

Wait for the app to leave the foreground before the single-top push #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucaCappelletti94 merged 1 commit into from
Oct 12, 2026
Merged

Wait for the app to leave the foreground before the single-top push #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ci/android/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ run_variant() {
timeout 900 adb shell am instrument -w -e class "rs.pushups.ci.$class" "${arguments[@]}" \
-e coverage true -e coverageFile "$files/jacoco.ec" "$package/androidx.test.runner.AndroidJUnitRunner" \
| tee "$out/$variant.txt" || true
# The device's side of a failure, which the runner's report does not show.
grep -q '^OK (' "$out/$variant.txt" || adb logcat -d -v time \
| grep -E 'pushups|FirebaseMessaging|FirebaseApp|NotificationService|ActivityTaskManager|AndroidRuntime' | tail -300
# The device's side of a failure, which the runner's report does not show, by tag, since system lines naming the package and UiDevice's polls for a title would fill the tail.
grep -q '^OK (' "$out/$variant.txt" || adb logcat -d -v time -s pushups:V FirebaseMessaging:V FirebaseApp:V \
NotificationService:V ActivityManager:V ActivityTaskManager:V AndroidRuntime:V TestRunner:V | tail -300
adb exec-out run-as "$package" cat files/pushups.profraw > "$out/$variant.profraw"
adb exec-out run-as "$package" cat files/jacoco.ec > "$out/$variant.ec"
}
Expand Down
9 changes: 8 additions & 1 deletion ci/android/src/androidTest/kotlin/rs/pushups/ci/SingleTopTapTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package rs.pushups.ci

import android.app.Activity
import android.app.ActivityManager
import android.content.Intent
import androidx.test.core.app.ActivityScenario
import androidx.test.ext.junit.runners.AndroidJUnit4
Expand Down Expand Up @@ -77,8 +78,10 @@ class SingleTopTapTest {
Probe.setHandler()
val id = "single-top-${UUID.randomUUID()}"
val title = "pushups tap $id"
// FCM shows a notification only while the app is in the background, and the Activity stays alive there.
// FCM shows a notification only while the process's importance is below foreground, which lags the home press, and the Activity stays alive there.
device.pressHome()
waitFor(UI_MS) { if (importance() != ActivityManager.RunningAppProcessInfo.IMPORTANCE_FOREGROUND) Unit else null }
?: error("the app was still in the foreground ${UI_MS / 1000} s after going home")
Pushes.send(
context,
id,
Expand Down Expand Up @@ -107,4 +110,8 @@ class SingleTopTapTest {
instrumentation.runOnMainSync { running.finish() }
}
}

/** This process's importance, which FCM reads to choose between showing a push and handing it to the app. */
private fun importance(): Int =
ActivityManager.RunningAppProcessInfo().also { ActivityManager.getMyMemoryState(it) }.importance
}
Loading