Repository navigation
fix(vgui): restore native IBorder virtual method order - #17
Merged
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zombie Panic 10210 calls native
IBorderslot 6 asGetName(), but the SDK insertedParseSideSettings(int, KeyValues*, IScheme*)there. This dispatched a no-argument call to a three-argument implementation and crashed during client UI initialization. Remove the helper from the public interface;Borderkeeps its private nonvirtual parser and native slots 0–7 retain their original order.Rebuild SDK consumers with this header. MetaHookSv/VGUI2Extension#34 restores native missing-image behavior and adds a regression that calls border slots 6/7 using the native ABI. MetaHookSv/MetaHookSv#968 pins both component fixes. Merge this SDK fix before the dependent plugin PR.
Validation with both component changes:
Start()return under CDB without runtime patches, traversing both previously failing paths.Full game startup remains blocked later by a separate Renderer error: missing client gamedata symbol
GameStudioRenderer_StudioDrawModel. Main-menu/map/visual regression is not claimed.