Repository navigation
[TRTLLM-16621][feat] Support DeepSeek-V4.1-Flash - #19727
Merged
Merged
Conversation
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #75832 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #75832 [ run ] completed with state
|
ziyixiong-nv
marked this pull request as ready for review
September 30, 2026 16:00
ziyixiong-nv
requested review from
Mgluhovskoi,
ZhanruiSunCh,
allisonlim-nv,
reasonsolo,
tburt-nv and
zhaoyangwang-nvidia
September 30, 2026 16:00
Signed-off-by: Alessio Netti <26897207+AlessioNetti@users.noreply.github.com> Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
…heduling Signed-off-by: Alessio Netti <26897207+AlessioNetti@users.noreply.github.com> Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Keep Engram history owned until request release, including warmup cleanup, and evict obsolete eager CSA2 staging without invalidating graph reservations. Adapt existing scheduler tests and isolate asynchronous test cleanup and admission timing. Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Reserve native index arenas and prefix-gather headroom in KV-cache sizing. Allow generation to progress when non-ADP remote-tail context cannot acquire KV pages while preserving replay isolation. Document CSA2 capabilities, cache ownership, and replay accuracy limits. Validation: pre-commit passed; incremental build and 479 targeted unit tests passed on AGA GB300. Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Restore the upstream shutdown loop and debug invariant, and remove the now-unused cinttypes include. Keep the CSA2 support PR focused on its required changes. Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Key CSA2 buffers by model layer, compression ratio, and role. Carry the family through owner aliases, physical identities, replay groups, and cached views while preserving existing disaggregated layer IDs. Adapt existing tests without adding test functions. Validation: pre-commit passed; incremental build without clean and 274 targeted tests passed on AGA GB300. Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Initialize the configured acceptance RNG slot in rejection-sampling metadata and update the RNG stubs to accept the required slot keyword. This keeps the existing packing and probability-law tests compatible with per-request RNG. Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Collaborator
|
PR_Github #77137 [ run ] completed with state |
Collaborator
Author
|
/bot reuse-pipeline |
Collaborator
|
PR_Github #77144 [ reuse-pipeline ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #77144 [ reuse-pipeline ] completed with state |
WeiHaocheng
approved these changes
Oct 11, 2026
3 of 5 tasks
1 task done
1 task done
1 task done
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add DeepSeek-V4.1 inference support to the PyTorch backend for:
The implementation includes CSA2 sparse attention, Engram, mHC, model-specific checkpoint loading, tokenizer/tool parsing, and registration of text-decoder and conditional-generation architectures.
Key Features
deepseek_v4/test_indexer_slot_mapping.pycoverage includes V4 FP4 context, eager decode and fused decode against the physical cache payload and scale bytes.Validation
GSM8K validation uses the NVFP4 checkpoint on 4 NVIDIA GB300 GPUs with TP4/EP4, attention DP, CUTEDSL MoE, and DSpark (
max_draft_len=5,block_size=5).GSM8K: 96.36% (1,271/1,319), with DSpark acceptance length 4.0000. Full evaluation uses batch size 32, 32-shot non-thinking prompts, greedy decoding, and a 1,024-token output limit.
PR Checklist
Dev Engineer Review
The available diff changes only import formatting in
tests/unittest/_torch/sampler/test_beam_search.py. It does not implement the DeepSeek-V4.1 features described in the PR objectives. No source or configuration behavior changes are present in the inspected diff.QA Engineer Review
One test file changed:
tests/unittest/_torch/sampler/test_beam_search.py. The changes reformat imports and local import statements; no test functions, selectors, or waivers changed. No integration tests changed, so no test-list registration applies. Coverage verdict: sufficient for the formatting-only changes. Test execution results are unavailable.Per-File QA Perspective
tests/unittest/_torch/sampler/test_beam_search.py— Existing beam-search coverage is unchanged; this diff only reformats imports. The file is not an integration test and does not require listing in the CI or manual-QA integration test lists.