Skip to content

fix(barrier): resolve cuDSS mtlayer path at runtime #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Sep 29, 2026
Merged

fix(barrier): resolve cuDSS mtlayer path at runtime #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d80aa3c
fix(barrier): resolve cuDSS mtlayer path at runtime, drop scary wording
ramakrishnap-nv Sep 23, 2026
0058b8b
fix review: resolve via dlsym before dladdr to avoid PLT stub
ramakrishnap-nv Sep 23, 2026
2f44c48
trim comments to minimum
ramakrishnap-nv Sep 23, 2026
0cbb7f9
address review: single std::string instead of raw-pointer dance, clar…
ramakrishnap-nv Sep 23, 2026
18f2437
simplify per review: use the mtlayer basename, drop runtime path disc…
ramakrishnap-nv Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,11 +875,11 @@ if (CUOPT_BUILD_CUSTOM_CUDSS_MTLAYER)
INSTALL_RPATH "\$ORIGIN"
)
set(CUDSS_MT_LIB_FILE_NAME "libcudss_mtlayer_cuopt.so")
else ()
# Full path, not just the basename, so the runtime dlopen pin (sparse_cholesky.cuh) and
# cudssSetThreadingLayer() resolve the exact same file CMake found (#1883).
set(CUDSS_MT_LIB_FILE_NAME "${CUDSS_MT_LIB_FILE}")
endif ()
# else: keep the basename already computed above (line 740) -- glibc's dlopen matches an
# already-loaded library by name before searching paths, so the runtime pin (sparse_cholesky.cuh)
# and cudssSetThreadingLayer()'s own dlopen still resolve to the same mapping. A full,
# build-time-resolved path isn't needed for that, and can go stale after install.

# cuopt_routing: VRP / routing engine (omitted when SKIP_ROUTING_BUILD=ON)
#
Expand Down
5 changes: 2 additions & 3 deletions cpp/src/barrier/sparse_cholesky.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,8 @@ class sparse_cholesky_cudss_t : public sparse_cholesky_base_t<i_t, f_t> {
if (!detail::pin_cudss_threading_layer(cudss_mt_lib_file)) {
Comment thread
ramakrishnap-nv marked this conversation as resolved.
settings.log.printf(
"cuDSS Threading layer : could not pin '%s'; falling back to single-threaded "
"cuDSS to avoid a possible crash during teardown. Set the CUDSS_THREADING_LIB "
"environment variable to an absolute path, or ensure the host provides "
"libgomp.so.1, to enable multi-threaded cuDSS.\n",
"cuDSS. Set the CUDSS_THREADING_LIB environment variable to an absolute path, or "
"ensure the host provides libgomp.so.1, to enable multi-threaded cuDSS.\n",
cudss_mt_lib_file);
} else {
cudssStatus_t threading_status = cudssSetThreadingLayer(handle, cudss_mt_lib_file);
Expand Down
Loading