Repository navigation
test ci - #333
test ci#333wendell-hom wants to merge 2 commits into
Conversation
|
/build |
 [Low impact] The changes affect ibverbs queue logging and README spacing. The PR needs the missing commit sign-off, corrected earlier commit title, and required documentation updates before merging. Findings
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -1,5 +1,6 @@ | |||
| # DAQIRI - Data Acquisition for Integrated Real-time Instruments | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Commit fd6c5bf has no Signed-off-by: trailer. The repository requires this trailer on every commit and rejects unsigned contributions. Add it with git commit -s --amend.
Rule Used: Every commit in the PR must contain a 'Signed-off-by: Name <email>' trailer (DCO). If any commit is missing the trailer, flag it and tell the contributor to amend with git commit -s --amend or to rebase with git rebase --signoff. See CONTRIBUTING... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| @@ -1,5 +1,6 @@ | |||
| # DAQIRI - Data Acquisition for Integrated Real-time Instruments | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Commit fd6c5bf is titled Dummy change. The repository requires an imperative title prefixed with the issue number, such as #123 - Add X. Amend the title to follow that format before merging.
Rule Used: Commit titles must use imperative mood and be prefixed with the GitHub issue number, e.g. #123 - Add X. PRs without an associated approved issue should be flagged. See CONTRIBUTING.md 'Coding Guidelines'. (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
/build |
8 similar comments
|
/build |
|
/build |
|
/build |
|
/build |
|
/build |
|
/build |
|
/build |
|
/build |
fd6c5bf to
404f904
Compare
|
/build |
1 similar comment
|
/build |
|
/build |
3 similar comments
|
/build |
|
/build |
|
/build |
Signed-off-by: Wendell Hom <whom@nvidia.com>
This branch has not been deployed
3 participants
No description provided.