Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# DAQIRI - Data Acquisition for Integrated Real-time Instruments


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Commit lacks required sign-off

Commit fd6c5bf has no Signed-off-by: trailer. The repository requires this trailer on every commit and rejects unsigned contributions. Add it with git commit -s --amend.

Rule Used: Every commit in the PR must contain a 'Signed-off-by: Name <email>' trailer (DCO). If any commit is missing the trailer, flag it and tell the contributor to amend with git commit -s --amend or to rebase with git rebase --signoff. See CONTRIBUTING... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Commit title breaks required format

Commit fd6c5bf is titled Dummy change. The repository requires an imperative title prefixed with the issue number, such as #123 - Add X. Amend the title to follow that format before merging.

Rule Used: Commit titles must use imperative mood and be prefixed with the GitHub issue number, e.g. #123 - Add X. PRs without an associated approved issue should be flagged. See CONTRIBUTING.md 'Coding Guidelines'. (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

<img src="docs/images/logo.svg" alt="DAQIRI" width="220"/>

**Send and receive Ethernet packets into CPU and GPU memory at hundreds of Gbps per GPU with a simple API.**
Expand Down
2 changes: 1 addition & 1 deletion src/engines/ibverbs/daqiri_ibverbs_engine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1372,7 +1372,7 @@ Status IbverbsEngine::devx_create_rq(IbvRxQueue& q, uint32_t stride_log, uint32_
// the public PTP epoch-nanosecond timestamp contract.
DEVX_SET(rqc, rqc, ts_format, MLX5_RQC_TIMESTAMP_FORMAT_REAL_TIME);
} else {
DAQIRI_LOG_CRITICAL(
DAQIRI_LOG_WARN(
"RX queue {}: real-time CQ timestamps are unsupported; using the device clock format",
q.queue_id);
}
Expand Down
Loading