fix node permissions for computedomain plugin - #2714
Open
rahulait wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
rahulait
force-pushed
the
fix-computedomain-node-permission
branch
from
August 4, 2026 14:42
0a42527 to
ae6bfc5
Compare
rahulait
marked this pull request as ready for review
August 4, 2026 14:48
rahulait
requested review from
cdesiniotis,
karthikvetrivel,
rajathagasthya,
shivamerla and
tariq1890
as code owners
August 4, 2026 14:48
Contributor
|
Don't we need to add the other permissions mentioned in the ClusterRole from the upstream DRA driver helm chart? |
Contributor
Author
|
Looks like ubuntu/canonical apt servers are having issues, driver installs are taking ages to finish and our e2e tests won't finish on time. |
Contributor
Author
Other required permissions remain in the existing general clusterrole https://github.com/NVIDIA/gpu-operator/blob/main/manifests/state-dra-driver/0200_kubeletplugin-clusterrole.yaml. Are you looking for any specific RBAC which is missing? |
cdesiniotis
approved these changes
Aug 6, 2026
rajathagasthya
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These permissions are coming from: https://github.com/kubernetes-sigs/dra-driver-nvidia-gpu/blob/9c52a7d50994adbf2fbb5f1ce2f6466fa3f9936f/deployments/helm/dra-driver-nvidia-gpu/templates/rbac-kubeletplugin.yaml#L17-L19
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Verified using: