Skip to content

fix node permissions for computedomain plugin #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahulait wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix node permissions for computedomain plugin #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions internal/state/testdata/golden/gpucluster-dra-driver-full-spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,35 @@ subjects:
namespace: test-operator
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: nvidia-dra-driver-kubeletplugin-computedomain
rules:
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- watch
- update
- patch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: nvidia-dra-driver-kubeletplugin-computedomain
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: nvidia-dra-driver-kubeletplugin-computedomain
subjects:
- kind: ServiceAccount
name: nvidia-dra-driver-kubeletplugin
namespace: test-operator
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: nvidia-dra-driver-kubeletplugin
Expand Down Expand Up @@ -306,15 +335,6 @@ rules:
- create
- update
- delete
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- watch
- update
- apiGroups:
- ""
resources:
Expand Down
9 changes: 0 additions & 9 deletions internal/state/testdata/golden/gpucluster-dra-driver-gpus-only.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,6 @@ rules:
- create
- update
- delete
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- watch
- update
- apiGroups:
- ""
resources:
Expand Down
9 changes: 0 additions & 9 deletions internal/state/testdata/golden/gpucluster-dra-driver-passthrough-support.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,6 @@ rules:
- create
- update
- delete
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- watch
- update
- apiGroups:
- ""
resources:
Expand Down
29 changes: 29 additions & 0 deletions manifests/state-dra-driver/0130_kubeletplugin-computedomain-role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,34 @@
{{- if .DRADriver.Spec.IsComputeDomainsEnabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: nvidia-dra-driver-kubeletplugin-computedomain
rules:
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- watch
- update
- patch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: nvidia-dra-driver-kubeletplugin-computedomain
subjects:
- kind: ServiceAccount
name: nvidia-dra-driver-kubeletplugin
namespace: {{ .Namespace }}
roleRef:
kind: ClusterRole
name: nvidia-dra-driver-kubeletplugin-computedomain
apiGroup: rbac.authorization.k8s.io
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: nvidia-dra-driver-kubeletplugin
Expand Down
9 changes: 0 additions & 9 deletions manifests/state-dra-driver/0200_kubeletplugin-clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,6 @@ rules:
- create
- update
- delete
- apiGroups:
Comment thread
rajathagasthya marked this conversation as resolved.
- ""
resources:
- nodes
verbs:
- get
- list
- watch
- update
- apiGroups:
- ""
resources:
Expand Down