chore(deps): declare the npm ecosystem for Dependabot - #13
Merged
Conversation
Also drops the template's 'copy to' line, which should not have survived into the copy. Signed-off-by: Bharath Sendhurpandi <bharathasl74185@gmail.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependabot here watched
github-actionsand nothing else, so@resvg/resvg-jsandarchiver— the two runtime dependencies this repository actually ships against, both with a committed lockfile — were unwatched. The0 open Dependabot alertsthis repository reports is a consequence of nothing looking, not of a clean tree.templates/dependabot.templateleaves this decision to each repository and asks that it be made "only when someone owns the review". This is that decision, made deliberately, and the trailing note in the file now records it instead of deferring it.The template's caution is about a Minecraft plugin compiled against a specific server API, where a bot raising the version is a compatibility change wearing a security change's clothes. Nothing in this repository is that.
@resvg/resvg-jsandarchiverare ordinary runtime dependencies of a build tool, and neither decides what this repository is compatible with. So there is noignorelist here, unlike the Gradle repositories.Majors are grouped separately from minors and patches, and in this repository that matters more than usual — see the honest caveat below.
Two other things this changes:
The header still read
# Copy to .github/dependabot.yml, which is an instruction to whoever copies the template and should not have survived into the copy.Keyframeandbrandboth replaced it with the house wording naming the file as this repository's copy and stating that the path is load-bearing; this now matches them.The trailing "adding the build's own ecosystem is a separate decision" note is replaced by the decision itself, since leaving a note that defers a decision directly above the decision would be confusing to the next reader.
The caveat worth reading
This repository has no build or test workflow. Its workflows are
agent-review-gate,dco,icons,scorecardandstandards— none of which builds the pack or runs the tools. So a Dependabot proposal here is verified by reading it and by runningnpm run buildlocally, not by CI.That is the main reason majors are grouped separately:
@resvg/resvg-jsis a native module, and a major is a rendering change that nothing currently in CI would catch. It is still worth having the proposals — knowing a CVE exists in a dependency is valuable independently of whether a pipeline can prove the fix is safe — but the review burden sits with a person here in a way it does not on the plugin repositories.Related Issues
None. Raised by an organisation-wide settings and security audit. The same gap is covered for
AntiSpeedrunby Ninja6-MC/AntiSpeedrun#105 and forSpiralGenesisby Ninja6-MC/SpiralGenesis#72;Keyframeandbrandstill need the npm equivalent.Type of Change
Checklist
SessionPulse; GitHub validates the manifest on push and reports a parse failure on the repository's Dependabot page.git commit -s), per section 5 of CONTRIBUTING.md.