feat: guest definitions as data

[NovusEdge]

What changed

Guest OS facts move from a Go literal to internal/guest/bundled/<name>.toml, with ~/.stoat/guests/*.toml merged over them per field. internal/tomlx is the one TOML decoder (path in every error, unknown keys, schema bound); vm.toml warns on an unknown key and recipe.toml rejects one.

Recipe scripts now get a rendered prelude over ssh and in the cloud-init seed: stoat_pkg_setup, stoat_pkg_install, stoat_svc_*, STOAT_OS, STOAT_INIT, STOAT_PKGMGR. escalate comes from the guest file instead of a hardcoded sudo. The capability table, the runtime package table and the scaffold text are gone from Go.

stoat guest ls and stoat guest show <name> expose the set, with --json. A non-empty os naming no loaded guest marks the VM broken instead of silently defaulting. provision is a kong alias of apply. xfce installs through the verbs.

Why

Adding a guest OS is a file. Three per-OS tables that could drift apart are now one.

Tests run

• just check and just test
• just e2e: NOT RUN. No KVM in the environment this was built in.

OS matrix

alpine, ubuntu, debian, fedora, arch: the bundled files are golden-tested against the deleted Go literal, and each prelude is a golden checked with sh -n. No live boot on any of them.

Docs

• docs/reference/guest.md, cli.md, json.md, writing-recipes.md

Before merge

xfce's install script was rewritten onto the verbs, so this wants a live boot. Run just e2e on a host with KVM.

[coderabbitai]

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 6c609a84-a51a-4869-b4f3-cd91c0852d40

📥 Commits

Reviewing files that changed from the base of the PR and between c7d34b2 and ce75a97.

📒 Files selected for processing (64)

• docs/SUMMARY.md
• docs/design/core-api.md
• docs/design/guest-subsystem.md
• docs/recipe-spec-v2.md
• docs/reference/cli.md
• docs/reference/guest.md
• docs/reference/json.md
• docs/writing-recipes.md
• internal/backend/backend.go
• internal/backend/cloudinit.go
• internal/cli/cli.go
• internal/cli/cli_test.go
• internal/cli/grammar.go
• internal/cli/json_test.go
• internal/cli/kong_test.go
• internal/cli/run_guest.go
• internal/cli/run_recipes.go
• internal/cli/wire/dto.go
• internal/cli/wire/dto_test.go
• internal/cloudinit/cloudinit.go
• internal/cloudinit/cloudinit_test.go
• internal/cloudinit/scripts.go
• internal/cloudinit/scripts_test.go
• internal/config/config.go
• internal/config/config_test.go
• internal/core/clone.go
• internal/core/guests.go
• internal/core/guests_test.go
• internal/core/vm.go
• internal/core/vm_test.go
• internal/guest/bundled/alpine.toml
• internal/guest/bundled/arch.toml
• internal/guest/bundled/debian.toml
• internal/guest/bundled/fedora.toml
• internal/guest/bundled/ubuntu.toml
• internal/guest/guest.go
• internal/guest/guest_test.go
• internal/guest/load.go
• internal/guest/load_test.go
• internal/guest/prelude.go
• internal/guest/prelude_test.go
• internal/guest/testdata/prelude/alpine.sh
• internal/guest/testdata/prelude/arch.sh
• internal/guest/testdata/prelude/debian.sh
• internal/guest/testdata/prelude/fedora.sh
• internal/guest/testdata/prelude/ubuntu.sh
• internal/recipes/bootstrap.go
• internal/recipes/bootstrap_test.go
• internal/recipes/bundled/xfce/install-alpine.sh
• internal/recipes/bundled/xfce/install-arch.sh
• internal/recipes/bundled/xfce/install-debian.sh
• internal/recipes/bundled/xfce/install.sh
• internal/recipes/bundled/xfce/recipe.toml
• internal/recipes/manifest.go
• internal/recipes/manifest_test.go
• internal/recipes/runtime.go
• internal/recipes/runtime_test.go
• internal/recipes/scaffold.go
• internal/sshx/sharemount.go
• internal/sshx/sshx.go
• internal/sshx/sshx_test.go
• internal/tomlx/tomlx.go
• internal/tomlx/tomlx_test.go
• internal/tui/app.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}