Repository navigation
test(incott): verify model code 0x02 on an original G23 Pro - #261
finnwasabi wants to merge 1 commit into
Conversation
Hardware test reports from a first-generation G23 Pro, cable only and 8K dongle only, both read-only. Model code 0x02 decodes to "G23 Pro" on both links and the 0xF1 sensor slot moves with the receiver as on the G23V2. Also records what the wireless report shows but does not explain: byte 8 is a 0x02 trailer on nearly every dongle reply, the discard read after the identity reply is shifted by one byte, and a stale 0xF1 lands in the 0x85/02 payload.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Capture evidence and identity decoding docs/incott-testing.md, src/incott/index.test.ts, captures/incott-g23-pro/README.md |
The documentation records the wired and wireless captures, hardware-confirmed model code 0x02, and observed response details. Tests check the model, PAW3950 sensor, display name, receiver detection, and dongle payload. The README identifies the connection setups and points to the test frames and testing write-up. |
Priority:
Estimated code review effort: 2 (Simple) | ~12 minutes
Change: Other
Suggested labels: area: tests, area: documentation
Suggested reviewers: vladidraganov
Merge Risk: 
Minimal · up to a5da8
-
This change documents original G23 Pro hardware behavior and adds identity-decoding coverage. No merge-blocking issue is identified; merge after normal checks pass.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title names the main change: adding tests that verify model code 0x02 on an original G23 Pro. The raw summary confirms a new identity-response test for model code 0x02 on cable and through the 8K receiver, plus documentation and captures for the same device. The title is specific and matches the changeset. It is conventional in form and uses a 'test(incott):' scope prefix. It is 59 characters, within a typical length limit.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds G23 Pro hardware reference captures and regression coverage for identity decoding over cable and receiver. Production behavior and device communication are unchanged, leaving no obvious material operational risk. Notes:
You can add or adjust custom eligibility rules. Learn more. |
First hardware sighting of Incott model code
0x02(G23), from a first-generation G23 Pro. Tests, docs and captures only; no codec or driver change.Device
093A:622C, product stringincott Esports G23 Pro mouse093A:522Cthrough the 8K dongle, product stringincott 8K wireless mouseTested on hardware
OpenMouse hardware test (control.openmouse.app BETA v2.0.59d, Chrome 156, Windows 11), 2026-10-29, once per link:
09 8f 01 02 00 f1 00 00 0009 8f 01 02 02 f0 f1 00 02Every report sent in both sessions is a query (
0x81to0x8F); nothing was written to the mouse. The two reports are committed unmodified undercaptures/incott-g23-pro/(no serial string is exposed).Changes
src/incott/index.test.ts: one test decoding both real frames to modelG23, PAW3950, "G23 Pro", with and without the 8K receiver.docs/incott-testing.md: marks the0x02row as hardware-confirmed and adds "A second model on hardware: the original G23 Pro".captures/incott-g23-pro/: the two hardware test reports and a README.Observed, not explained (documented, no code change)
0x02on 69 of 70 full dongle replies whatever the command, so it looks like a per-link trailer rather than identity data.09 8f 01 02 02 f0 f0 f1 02, 4 of 4). The driver never decodes that read, so naming is unaffected.0x85/0x02reply carried a stale0xF1at byte 5 (09 85 02 03 0a f1 00 00 02), left over from the identity reply.2("Low") on both links; this does not settle the millimetre mapping.Checks
npm run check: 2716 tests pass,npm pack --dry-runclean,git diff --checkclean.Related artwork request: OpenMouse-Project/openmouse#1276.
Note
Verify Incott model code 0x02 on an original G23 Pro with test fixtures
Macroscope summarized a5da85c.
Summary by CodeRabbit