Skip to content

Make WeakAttribute.base public #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 2 commits into from
Sep 7, 2026
+18 −2
Merged

Make WeakAttribute.base public #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae157a7
Make WeakAttribute.base public
Kyle-Ye Sep 6, 2026
e2ab8d0
Test WeakAttribute.base compatibility
Kyle-Ye Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Scripts/CI/ag_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ filepath() {
}

REPO_ROOT="$(dirname $(dirname $(dirname $(filepath $0))))"
DARWINPRIVATEFRAMEWORKS_FALLBACK_REVISION="0cec3b3219dd2d99818e861e3dca7598e7554f98"
DARWINPRIVATEFRAMEWORKS_FALLBACK_REVISION="157294d5c4d5bde4e13e24347f0f8c50e47c79dc"

clone_checkout_ag() {
cd $REPO_ROOT
Expand Down
2 changes: 1 addition & 1 deletion Sources/OpenAttributeGraph/Attribute/Weak/WeakAttribute.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public import OpenAttributeGraphCxx
@propertyWrapper
@dynamicMemberLookup
public struct WeakAttribute<Value> {
var base: AnyWeakAttribute
public var base: AnyWeakAttribute

public init(base: AnyWeakAttribute) {
self.base = base
Expand Down
16 changes: 16 additions & 0 deletions ...OpenAttributeGraphCompatibilityTests/Attribute/Weak/WeakAttributeCompatibilityTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,21 @@ struct WeakAttributeCompatibilityTests {
let attr = Attribute(value: 0)
_ = WeakAttribute(attr)
}

@Test
func base() {
let first = Attribute(value: 1)
let second = Attribute(value: 2)
var weak = WeakAttribute(first)
#expect(weak.base == AnyWeakAttribute(first.identifier))

weak.base = AnyWeakAttribute(second.identifier)
#expect(weak.attribute == second)
#expect(weak.wrappedValue == 2)

weak.base = AnyWeakAttribute(nil)
#expect(weak.attribute == nil)
#expect(weak.wrappedValue == nil)
}
}
#endif
Loading