Skip to content

Make WeakAttribute.base public - #241

Merged
Kyle-Ye merged 2 commits into
mainfrom
feature/weak
Sep 7, 2026
Merged

Make WeakAttribute.base public#241
Kyle-Ye merged 2 commits into
mainfrom
feature/weak

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 7, 2026

Copy link
Copy Markdown
Member

Expose WeakAttribute.base as a public mutable property so callers can read and replace the underlying AnyWeakAttribute.

Add a compatibility test for reading, replacing, and clearing the reference. Update the CI DarwinPrivateFrameworks revision to include the public interface. All six WeakAttribute and AnyWeakAttribute compatibility tests passed on macOS.

Dependency

@github-actions github-actions Bot added enhancement New feature or request test related labels Sep 7, 2026
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.17%. Comparing base (ccacd7d) to head (e2ab8d0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   32.17%   32.17%           
=======================================
  Files          71       71           
  Lines        2601     2601           
=======================================
  Hits          837      837           
  Misses       1764     1764           
Flag Coverage Δ
ios 32.19% <ø> (ø)
macos 10.15% <ø> (ø)
ubuntu 12.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nAttributeGraph/Attribute/Weak/WeakAttribute.swift 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Sep 7, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenAttributeGraph-Package 0 % 138 0 138 52c68a2b2

Builds 🔨

Scheme Status Duration Commit
OpenAttributeGraph 5.0s 52c68a2b2
OpenAttributeGraph-Package 16.2s 52c68a2b2

@Kyle-Ye
Kyle-Ye merged commit b5d71c9 into main Sep 7, 2026
11 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/weak branch September 7, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant