Repository navigation
fix(admin): the sign-in pages carry the shop's name, logo and colours - #468
Conversation
The admin login and two-factor pages printed "PNLCS" in the title, the heading and the footer, with a hard-coded "P" badge in the starter blue, whatever the white-label settings said. They now use company_name() (the white-label name first), the uploaded logo or the name's initial, the favicon and the theme colours. Both views are added to the ThemeComposer list so they get the same variables as the client sign-in page; the favicon and the mark are two small partials. Fixes Panelica#457.
|
Merged, thank you. Both tests red on 1.29.0, green after; the composer list now carries the two admin auth views, so |
|
Released in 1.30.0, the stable channel, offered to every installation. Gates on the tag and that package: full suite 5463 passed in parallel plus the 17 serial installer tests (0 failed, 5 skipped); 276 translation and parity tests green; the update lab 14 scenarios ALL GREEN; the real package updated the last stable (1.29.0 → 1.30.0, 13 checks) and the last beta (1.25.1-beta.1 → 1.30.0, 14 checks), each installed from its published package in the published runtime image with the signature checked by the key built into the application; the three uploaded assets re-downloaded and compared byte for byte before publishing. |
Fixes #457.
The admin login and two-factor pages printed "PNLCS" in the title, the heading and the footer, with a hard-coded "P" badge in the starter blue, whatever the white-label settings said.
The change
company_name(), which reads the white-label name first.ThemeComposerlist, so they get the same variables as the client sign-in page. The favicon and the mark are two small partials underadmin/auth/partials.Tests
tests/Feature/AdminLoginBrandingTest.phpchecks the white-label name instead of PNLCS, and that an uploaded logo replaces the initial. Both tests fail on main and pass with the change. The existing admin auth and two-factor tests still pass. Full suite: 5,428 passed; the 2 failures (CurrencyAndBackupTest, MailLinkHostTest) fail the same way on main.