Repository navigation
Replace the USE_QT_UI global with use_qt_ui() - #1843
Merged
Merged
Conversation
USE_QT_UI was a mutable global that each executable defined (true in SerialPrograms, false in SerialProgramsCommandLine) and the serial connection code read. Make it a function each executable defines next to its main(), so the value is still chosen at link time but nothing can change it at run time. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USE_QT_UIwas a mutable global that each executable defined (truein SerialPrograms,falsein SerialProgramsCommandLine) and the serial connection code read. This makes it a function,use_qt_ui(), that each executable defines next to itsmain(), so the value is still picked at link time but nothing can change it at run time. No behavior change; it prepares a headless unit test runner, which defines it asfalse. Tested by compiling the library and both executables on macOS.