Repository navigation
Conversation
019 and 020 are Rowan's lines with a name tab over the intro's sparkle background; the second's long line runs into the box's right end. Used by PokemonBDSP's intro screen tests (dayfine/Arduino-Source bdsp/actions-v4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The X menu detector reads the menu's blue bottom bar, so it also sees a new game's menu, which has only BAG and OPTIONS. s38_xmenu is that menu (run 5's failure); the closed set is HOME, two overworld scenes and two intro screens from run 4 that must not read as a menu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Move the frames from PokemonBDSP/AutoStory/ to the detectors they test, named <description>_True/False like every other game: DialogDetector for Rowan's two name-tab lines, MenuDetector for the new-game menu (BAG and OPTIONS only) and five screens that are not a menu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
An ordinary box whose right end is white where ShortDialogDetector's old check looks; the positive next to the two long-first-line screens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…n TOWN MAP) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…dialogue boxes, cloud shadows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test screens for two BDSP detectors that a new game run trips over, in the usual
PokemonBDSP/<Detector>/<description>_True|False.pnglayout (the first files underPokemonBDSP/). ShortDialogDetector misses some intro lines with a name tab: the long first line covers the small white box it checks. MenuDetector misses the new-game X menu with only BAG and OPTIONS, and menus with "NEW" tags, because the tag covers what it checks. The_Falsescreens (HOME, overworld scenes, intro dialog, Floaroma's cloud shadows) must not match.The detector fixes and the tests that read these files come later in an Arduino-Source PR (now dayfine/Arduino-Source#152); until then nothing reads them, so this changes no test results. Frames were captured at 1080p from a Switch through a capture card.
cc @Developer-Butters
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E